Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a model management notebook #419

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Conversation

igor-davidyuk
Copy link
Contributor

This PR introduces a new example notebook showcasing work with models and algorithms

@igor-davidyuk igor-davidyuk requested a review from ljcornel May 22, 2024 06:43
Copy link
Collaborator

@ljcornel ljcornel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for adding this! I've added a few minor comments, but I think the overall approach is pretty good.

I realize it may be sensitive to changes in the default algorithms, or certain user changes in the project it relies on. But I don't think it's a big risk, it should still run but maybe lose some of it's effectiveness in certain cases.

notebooks/013_manage_models.ipynb Outdated Show resolved Hide resolved
notebooks/013_manage_models.ipynb Outdated Show resolved Hide resolved
notebooks/013_manage_models.ipynb Outdated Show resolved Hide resolved
notebooks/013_manage_models.ipynb Outdated Show resolved Hide resolved
@igor-davidyuk igor-davidyuk force-pushed the idavidyu/notebook-model-client branch from 5b8bdf8 to 2a295c4 Compare May 31, 2024 08:17
@igor-davidyuk igor-davidyuk requested a review from ljcornel May 31, 2024 08:20
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Copy link
Collaborator

@ljcornel ljcornel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, could you just update the spelling of Geti (GETi -> Geti)?

@igor-davidyuk
Copy link
Contributor Author

Looks good to me, could you just update the spelling of Geti (GETi -> Geti)?

Done!

Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk igor-davidyuk merged commit f830040 into main Jun 3, 2024
11 checks passed
@igor-davidyuk igor-davidyuk deleted the idavidyu/notebook-model-client branch June 3, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants