Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End support for Platforms versions lower than 1.15 #397

Merged
merged 13 commits into from
May 7, 2024
Merged

End support for Platforms versions lower than 1.15 #397

merged 13 commits into from
May 7, 2024

Conversation

igor-davidyuk
Copy link
Contributor

@igor-davidyuk igor-davidyuk commented Apr 24, 2024 •
edited
Loading

  • Remove logic branching allowing to interact with Platforms older than 1.15
  • Add unit tests

This PR drops support for older GETi Platform versions (1.8 and older). It ends support for all interactions with older Platforms, including logging in.

It opens several paths for users:

  1. Users can upgrade their platform to 2.0 and use the GETi-SDK 2.0 package with it.
  2. Users who decide to stay with an older Platform version can use a corresponding GETi-SDK package.
  3. Users with complex pipelines, including model deployments by both legacy and contemporary versions of the Platform, should use separate virtual environments.

SaaS users should not be affected by these changes.

@igor-davidyuk igor-davidyuk requested a review from ljcornel April 24, 2024 07:30
@igor-davidyuk igor-davidyuk marked this pull request as ready for review May 1, 2024 14:38
@igor-davidyuk igor-davidyuk force-pushed the idavidyu/drop-support-legacy-platforms branch from 715d5aa to 1fde49b Compare May 2, 2024 15:37
Radwan-Ibrahim
Radwan-Ibrahim reviewed May 3, 2024
View reviewed changes
geti_sdk/http_session/geti_session.py Outdated Show resolved Hide resolved
geti_sdk/http_session/geti_session.py Outdated Show resolved Hide resolved
geti_sdk/http_session/geti_session.py Show resolved Hide resolved
ljcornel
ljcornel reviewed May 6, 2024
View reviewed changes
geti_sdk/http_session/geti_session.py Show resolved Hide resolved
geti_sdk/http_session/geti_session.py Show resolved Hide resolved
geti_sdk/http_session/geti_session.py Show resolved Hide resolved
geti_sdk/http_session/geti_session.py Show resolved Hide resolved
geti_sdk/http_session/geti_session.py Show resolved Hide resolved
ljcornel
ljcornel reviewed May 6, 2024
View reviewed changes
Copy link
Collaborator

@ljcornel ljcornel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the GetiSession.authenticate method, we should add some error handling to raise a user-friendly error for the following cases:

  1. User attempts to authenticate with a legacy geti version
  2. User attempts to authenticate with username/password on a Geti SaaS instance

igor-davidyuk and others added 11 commits May 7, 2024 12:11
@igor-davidyuk
remove support for older geti versions
2e927fc 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk
fix unit tests
be38866 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk
remove legacy authentication mechanism
ca61136 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk
fix geti session proxies handling
1396bd3 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk
remove deprecated parameters
709ffd4 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk
raise exception when connecting to legacy server
dce2ef1 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk
fix media annotation_state_per_task field
786ff70 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk
fix algorithm helpers
52dd1b3 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk
add model is_filter_pruning_enabled field to OptimizationCapabilities
b829abc 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk
check otx version in deplyed model
66f0d60 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk @Radwan-Ibrahim
Update legacy platform warning
467da7a 
Co-authored-by: Radwan Ibrahim <Radwan.Ibrahim@intel.com>
@igor-davidyuk igor-davidyuk force-pushed the idavidyu/drop-support-legacy-platforms branch from d91a56d to 5bf7790 Compare May 7, 2024 13:25
@igor-davidyuk
prevent password authentication to saas
5bf7790 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk
add unit tests
9ee2808 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
ljcornel
ljcornel approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@ljcornel ljcornel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot. I love how much this simplifies the code :)

@ljcornel ljcornel merged commit 3ae57a4 into main May 7, 2024
11 checks passed
@ljcornel ljcornel deleted the idavidyu/drop-support-legacy-platforms branch May 7, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radwan-Ibrahim Radwan-Ibrahim Radwan-Ibrahim left review comments

@ljcornel ljcornel ljcornel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-davidyuk @Radwan-Ibrahim @ljcornel