Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default_workspace to possible default workspace names #394

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add default_workspace to possible default workspace names #394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion geti_sdk/utils/workspace_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def get_default_workspace_id(rest_session: GetiSession) -> str:
f"Unexpected response from cluster: {workspaces}. Expected to receive a "
f"dictionary containing workspace data."
)
default_workspace_names = ["default", "default workspace"]
default_workspace_names = ["default", "default workspace", "default_workspace"]
Copy link
Contributor

@Radwan-Ibrahim Radwan-Ibrahim Apr 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljcornel @igor-davidyuk we are going to allow the users to change the workspace name soon, so I would recommend not using the names for getting the default one. It is better to ask the user the choose the workspace, or sorting them using he creation time and taking the oldest one.

default_workspace = next(
(
workspace
Expand Down
Loading