Remove dependency on OTX #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
igor-davidyuk
force-pushed
the
idavidyu/remove-otx-dependency
branch
from
6302563 to
29f5137
Compare
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
ljcornel
reviewed
Apr 25, 2024
| @@ -426,31 +425,12 @@ def generate_ovms_config(self, output_folder: Union[str, os.PathLike]) -> None: | |||
| ovms_model_dir = os.path.join(ovms_models_dir, model_name, model_version) | |||
| source_model_dir = model.model_data_path | |||
|
|
|||
| if otx.__version__ >= "1.4.0": | |||
There was a problem hiding this comment.
This should not be removed I believe, it applies for otx versions 1.4 and up. It's function is to embed the preprocessing in the model graph, and save the updated model.
This is required, otherwise once the model is loaded into OVMS it will not be able to handle the input that we send to it later on.
There was a problem hiding this comment.
Wow, I probably removed the wrong logical branch, good catch!
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
ljcornel
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles OTX removal, which makes it impossible to perform inference with deployments generated by Platforms of versions older than 1.15 (OTX 1.4.x and older)