Decouple visualizer for OTX #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
ljcornel
reviewed
Mar 19, 2024
| """ | ||
| Visualize the predicted output by drawing the annotations on the input image. | ||
|
|
||
| :example: |
There was a problem hiding this comment.
I'm wondering about this example, I think it'd be better to change it to use the Deployment API that we have in the SDK. This looks like it still shows the OTX api for prediction
|
|
||
| :param image: Image to be shown. | ||
| """ | ||
| if not self.no_show: |
There was a problem hiding this comment.
This seems weird, I'd say we should at least log that .show has been called while the interactive output was suppressed. Otherwise it might leave a user wondering why they are not seeing any output.
There was a problem hiding this comment.
I agree it looks odd 😁
This parameter is there for the future when Visualizer will be able to save images without showing them.
The logging should be there, I agree. But as it is not used yet, I will just remove this one for now
igor-davidyuk
commented
Mar 19, 2024
ljcornel
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the Visualizer entity