Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing requirements #877

Merged

Conversation

cih9088
Copy link
Contributor

@cih9088 cih9088 commented Mar 22, 2023

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (967180d) 78.52% compared to head (4b04278) 78.52%.

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.1.0     #877   +/-   ##
===============================================
  Coverage           78.52%   78.52%           
===============================================
  Files                 206      206           
  Lines               24961    24961           
  Branches             5011     5011           
===============================================
  Hits                19601    19601           
  Misses               4235     4235           
  Partials             1125     1125           
Flag Coverage Δ
macos-11_Python-3.8 77.50% <ø> (ø)
ubuntu-20.04_Python-3.8 78.51% <ø> (?)
windows-2019_Python-3.8 78.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim changed the base branch from develop to releases/1.1.0 March 22, 2023 02:22
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cih9088

I changed the target branch to releases/1.1.0. Please rebase this PR to the latest releases/1.1.0 and push again.

@cih9088 cih9088 force-pushed the fix/missing-requirement branch from c302854 to 4b04278 Compare March 22, 2023 02:30
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonjuleee I think we need to have a time to update ./3rd-party.txt before releasing 1.1.0.

@vinnamkim vinnamkim added this to the 1.1.0 milestone Mar 22, 2023
@wonjuleee wonjuleee self-requested a review March 22, 2023 04:43
@vinnamkim vinnamkim added the FIX defect fix label Mar 22, 2023
@wonjuleee
Copy link
Contributor

LGTM

@wonjuleee I think we need to have a time to update ./3rd-party.txt before releasing 1.1.0.

Yes, I think so. Let me request to generate this from the system.

@vinnamkim vinnamkim merged commit d14f49b into openvinotoolkit:releases/1.1.0 Mar 22, 2023
@cih9088 cih9088 deleted the fix/missing-requirement branch April 20, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIX defect fix RELEASE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants