-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing requirements #877
Add missing requirements #877
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## releases/1.1.0 #877 +/- ##
===============================================
Coverage 78.52% 78.52%
===============================================
Files 206 206
Lines 24961 24961
Branches 5011 5011
===============================================
Hits 19601 19601
Misses 4235 4235
Partials 1125 1125
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the target branch to releases/1.1.0
. Please rebase this PR to the latest releases/1.1.0
and push again.
c302854
to
4b04278
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wonjuleee I think we need to have a time to update ./3rd-party.txt
before releasing 1.1.0.
Yes, I think so. Let me request to generate this from the system. |
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.