-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug in the previous behavior when importing nested datasets in the project #1243
Conversation
…the project Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1243 +/- ##
========================================
Coverage 80.53% 80.53%
========================================
Files 270 270
Lines 30232 30238 +6
Branches 5898 5903 +5
========================================
+ Hits 24348 24353 +5
Misses 4506 4506
- Partials 1378 1379 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In overall, it looks good to me, but I have a one quick question. Is this fix available only for coco and yolo formats?
As we discussed, it is available only for the yolo formats. This is because importing datasets from sub-directories at once is not commonly available for all data formats. |
Summary
Dataset.import_from(./some_project)
for the following directory structure, the imported dataset include
dataset_1
anddataset_2
.How to test
Added an integration test for this scenario.
Checklist
License
Feel free to contact the maintainers if that's a concern.