Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Inferencer #60

Merged
merged 10 commits into from
Jan 10, 2022
Merged

Fix Inferencer #60

merged 10 commits into from
Jan 10, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

Comments

  • I have refactored the code a bit and moved the inferencer to deploy folder. This is intended to comply with the upcomming refactor
  • The place in base Inferencer where the meta data is retrieved from the model might require refactor.
  • Also, I have changed the default category for padim and stfpm to bottle as that's the example used in the README.

Changes

🐞 fix torch inferencer
🛠 Add metadata to inferencer
🧪 Add Inferencer tests

Tests

image

🐞 fix torch inferencer
942e5c9 
🛠  Add metadata to inferencer
🧪 Add Inferencer tests
@ashwinvaidya17 ashwinvaidya17 added the Bug Something isn't working label Jan 6, 2022
@ashwinvaidya17 ashwinvaidya17 linked an issue Jan 6, 2022 that may be closed by this pull request
Inference Bug - Too many variables to unpack #56
Closed
samet-akcay
samet-akcay reviewed Jan 6, 2022
View reviewed changes
tools/inference.py Outdated Show resolved Hide resolved
samet-akcay
samet-akcay reviewed Jan 6, 2022
View reviewed changes
tools/inference.py Outdated Show resolved Hide resolved
💬 Address PR comments
b05c551 
🛠  Fix mypy issues
djdameln
djdameln reviewed Jan 7, 2022
View reviewed changes
anomalib/core/callbacks/compress.py Show resolved Hide resolved
anomalib/deploy/inferencers/base.py Outdated Show resolved Hide resolved
anomalib/deploy/inferencers/base.py Outdated Show resolved Hide resolved
anomalib/deploy/inferencers/base.py Outdated Show resolved Hide resolved
anomalib/deploy/inferencers/torch.py Outdated Show resolved Hide resolved
anomalib/deploy/inferencers/base.py Show resolved Hide resolved
samet-akcay
samet-akcay reviewed Jan 7, 2022
View reviewed changes
tools/inference.py Outdated Show resolved Hide resolved
@ashwinvaidya17 ashwinvaidya17 merged commit ee89682 into development Jan 10, 2022
@ashwinvaidya17 ashwinvaidya17 deleted the fix/ashwin/inferencer branch January 10, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdameln djdameln djdameln left review comments

@samet-akcay samet-akcay samet-akcay approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inference Bug - Too many variables to unpack
3 participants
@ashwinvaidya17 @samet-akcay @djdameln