Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform behaviour+documentation #1953

Merged
merged 7 commits into from
May 2, 2024

Conversation

djdameln
Copy link
Contributor

@djdameln djdameln commented Apr 5, 2024

📝 Description

  • This PR implements a minor change to the transforms workflow. When only a train_transform (and not an eval_transform) is passed to the datamodule, Anomalib will now use the default model-specific transform as the eval transform. Previously it would re-use the train_transform to prevent shape mismatch. We now also raise a warning to urge the user to check their transform configs if only a train_transform or eval_transform is provided. The new behaviour may be a bit less confusing to users.
  • Adds documentation for the transform functionality
  • Updates the data configs, which still defined some depreceted arguments (this was a leftover from v0.x)

Fixes

#2020

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts! I have one minor comment

docs/source/snippets/data/transforms/inference_cli.sh Outdated Show resolved Hide resolved
Co-authored-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
@samet-akcay samet-akcay merged commit 8f5fa93 into openvinotoolkit:main May 2, 2024
7 checks passed
@djdameln djdameln deleted the train-eval-transform branch December 4, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants