Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate train and validation transformations #168

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Separate train and validation transformations #168

merged 4 commits into from
Apr 6, 2022

Conversation

alexriedel1
Copy link
Contributor

This introduces separate training and validation transformation to be defined in the respective model configs.

If nothing is defined, it will fall back to default behaviour at any time.
If only training transformations are defined, validation transformations will be set equal to those.

An alternative for handling this is raising a user warning, that one kind of transformations is defined and the other is not?

If there's something missing or if this should be implemented completely different, let me know.

@samet-akcay
Copy link
Contributor

@alexriedel1 the CI has failed due to formatting. We bumped up the black version due to some dependency conflicts, causing some formatting changes. Would you be able to update your black version, and run the formatting again.
For more details, see here:

https://github.com/openvinotoolkit/anomalib/blob/development/tox.ini#L16
https://github.com/openvinotoolkit/anomalib/blob/development/.pre-commit-config.yaml#L15

@alexriedel1
Copy link
Contributor Author

@alexriedel1 the CI has failed due to formatting. We bumped up the black version due to some dependency conflicts, causing some formatting changes. Would you be able to update your black version, and run the formatting again. For more details, see here:

https://github.com/openvinotoolkit/anomalib/blob/development/tox.ini#L16 https://github.com/openvinotoolkit/anomalib/blob/development/.pre-commit-config.yaml#L15

should be fine now.

Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check Yaml...............................................................Passed
Check for added large files..............................................Passed
Debug Statements (Python)................................................Passed
Detect Private Key.......................................................Passed
black....................................................................Passed
isort....................................................................Passed
prettier.................................................................Passed
flake8...................................................................Passed
pylint...................................................................Passed
mypy.....................................................................Passed
pydocstyle...............................................................Passed

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a nice enhancement

@samet-akcay samet-akcay added Pre-Processing Enhancement New feature or request labels Apr 1, 2022
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexriedel1!

Our CI is broken now. We'll merge this PR once we fix the CI and run the PR one more time.

@samet-akcay samet-akcay linked an issue Apr 5, 2022 that may be closed by this pull request
@alexriedel1
Copy link
Contributor Author

I just merged the development branch

@samet-akcay samet-akcay merged commit 15378f3 into openvinotoolkit:development Apr 6, 2022
@alexriedel1 alexriedel1 deleted the transform_train_val branch April 6, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Pre-Processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate train and test augmentation
3 participants