c_idx cast to LongTensor in random sparse projection

[alexriedel1]

Fixing #111

[innat]

components[i, c_idx.long()] = data.double()

or 

c_idx = [int(t.item()) for t in c_idx]
components[i, c_idx] = data.double()

It's taking really much time to get coreset from embedding. Is it expected in patchcore? I'm running on CPU with

num_workers: 1 # 36

[djdameln]

It's taking really much time to get coreset from embedding. Is it expected in patchcore? I'm running on CPU with

Yes, the coreset computation in the training step is optimized for GPU. Inference should run fine on CPU.

[djdameln]

Thanks for reporting and addressing this issue. I would suggest constructing c_idx as long type, like so:

c_idx = torch.tensor(
    sample_without_replacement(
        n_population=n_features, n_samples=nnz_idx, random_state=self.random_state
    ),
    dtype=torch.int64
)

That way we don't need to cast it afterwards.

[djdameln]

Thanks!

[ashwinvaidya17]

@alexriedel1 Thanks for your contribution! Let's merge after CI passes.

[ashwinvaidya17]

@alexriedel1 There seems to be a minor black formatting issue. https://github.com/openvinotoolkit/anomalib/runs/5315789777?check_suite_focus=true Can you address it? I think it would be convenient for you if you install pre-commit hooks.

pip install pre-commit
pre-commit install
pre-commit run --all-files

[alexriedel1]

@alexriedel1 There seems to be a minor black formatting issue. https://github.com/openvinotoolkit/anomalib/runs/5315789777?check_suite_focus=true Can you address it? I think it would be convenient for you if you install pre-commit hooks.

pip install pre-commit
pre-commit install
pre-commit run --all-files

I guess thats what black wanted to reformat. Unfortunately I wasnt abel to run the pre commit hooks..

[ashwinvaidya17]

Thanks for quickly addressing this!

[ashwinvaidya17]

I guess thats what black wanted to reformat. Unfortunately I wasnt abel to run the pre commit hooks..

Can you share the error? We will try to update the docs to address this.

[alexriedel1]

I guess thats what black wanted to reformat. Unfortunately I wasnt abel to run the pre commit hooks..

Can you share the error? We will try to update the docs to address this.

It's an issue on my side. I'm having strange permission issues when trying to run the hooks so dont worry..