UCT/ROCM: add control of ipc cache usage #10497
Open
+50
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgargabriel
force-pushed
the
topic/disable-ipc-cache
branch
from
1183f77 to
70ab0b9
Compare
edgargabriel
changed the title
edgargabriel
changed the title
edgargabriel
force-pushed
the
topic/disable-ipc-cache
branch
from
70ab0b9 to
17166be
Compare
yosefe
reviewed
Feb 20, 2025
src/uct/rocm/ipc/rocm_ipc_iface.c
Outdated
| @@ -201,6 +205,7 @@ static UCS_CLASS_INIT_FUNC(uct_rocm_ipc_iface_t, uct_md_h md, uct_worker_h worke | |||
|
|
|||
| self->config.min_zcopy = config->min_zcopy; | |||
| self->config.latency = config->latency; | |||
| self->config.enable_ipc_handle_cache = config->enable_ipc_handle_cache; | |||
There was a problem hiding this comment.
code style - align = on column
yosefe
previously approved these changes
Feb 21, 2025
edgargabriel
force-pushed
the
topic/disable-ipc-cache
branch
from
c36008b to
e0c0ff8
Compare
|
squashed the commits |
rakhmets
reviewed
Feb 28, 2025
rakhmets
reviewed
Mar 3, 2025
tvegas1
previously approved these changes
Mar 3, 2025
rakhmets
approved these changes
Mar 3, 2025
tvegas1
approved these changes
Mar 3, 2025
yosefe
approved these changes
Mar 4, 2025
|
@edgargabriel pls squash |
- add a UCX parameter that allows to control whether we want to use the ipc handle cache. - restructure structs in header Signed-off-by: Edgar Gabriel <Edgar.Gabriel@amd.com> Co-authored-by: Raul Akhmetshin <74596089+rakhmets@users.noreply.github.com>
edgargabriel
force-pushed
the
topic/disable-ipc-cache
branch
from
a94ed0e to
918e22b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
add a UCX parameter that allows to control whether we want to use the rocm_ipc handle cache.
Why?
There are some situation where caching the IPC handles/registrations is detrimental for a multitude of reasons.