UCT/IB/MLX5/DV: device memory allocation debug logs #10495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyastreb
approved these changes
Feb 17, 2025
yosefe
requested changes
Feb 17, 2025
Comment on lines
+2074
to
+2075
| uct_ib_device_name(&md->dev), alloc_name, address, | ||
| UCS_PTR_BYTE_OFFSET(address, dm_attr.length), dm_attr.length, dm, |
There was a problem hiding this comment.
do we really need to print both end address and length? IMO length is enough
| @@ -2068,6 +2068,13 @@ uct_ib_mlx5_devx_device_mem_alloc(uct_md_h uct_md, size_t *length_p, | |||
| *length_p = dm_attr.length; | |||
| *address_p = address; | |||
| *memh_p = memh; | |||
|
|
|||
| ucs_debug("%s: allocated device memory (%s) %p..%p length %zu, dm %p, mkey " | |||
| uct_ib_device_name(&md->super.dev)); | ||
|
|
||
| #else | ||
| ucs_debug("UCX was compiled without --with-dm configuration"); |
There was a problem hiding this comment.
IMO this debug log is not needed as we don't usually have such messages, and we can know the compilation defines from ucx_info -b
Comment on lines
+2177
to
+2178
| ucs_debug("%s: KSM over device memory is supported", | ||
| uct_ib_device_name(&md->super.dev)); |
There was a problem hiding this comment.
- "%s: device memory allocation is supported"
- move this log after line 2167? we could get here also if uct_ib_mlx5_devx_reg_atomic_key failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adding missing debug logs to IB device memory allocations.
Why?
Getting a better indication of whether device memory was used in runtime and the cause.