Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the leg index into frameLeg callback #94

Closed
randolphjones opened this issue Mar 23, 2020 · 0 comments · Fixed by #97
Closed

Pass the leg index into frameLeg callback #94

randolphjones opened this issue Mar 23, 2020 · 0 comments · Fixed by #97
Assignees
Labels
AS2 enhancement New feature or request HIGH High Priority

Comments

@randolphjones
Copy link

randolphjones commented Mar 23, 2020

We have done the necessary integration work to frame a trip leg within the trip tools map when the associated "map" icon button is clicked next to the associated leg. We are blocked from completing this work though because the frameLeg callback does not include the leg index when invoked inside of the OTP ItineraryBody component (to be more specific it's called inside of PlaceRow) I think this should be a simple matter of wrapping the onClick handler with an arrow function and supplying the legIndex as an argument to frameLeg however, we're open to any other things you may want to do (i.e. passing the entire leg if you think it meets your own needs).

At the very least, we need some reference to the leg that's just been clicked by the user. If I can offer up any more detail or clarification then please let me know. I think this should be fairly straightforward.

@fpurcell since we are so close to wrapping this feature, what are the changes of us getting this request expedited? I think this can be wrapped with a very small update. Let me know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AS2 enhancement New feature or request HIGH High Priority
Projects
None yet
3 participants