-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phone Verification #224
Phone Verification #224
Conversation
…after accepting terms. This is for compatibility with the phone verification backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
State management looks much better now. I have a few comments on probably nice-to-have items, but this seems good to go as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this behemoth merged for now because it's becoming too unwieldy and mostly looks good, but I would like to see a mention of the expiration time for a code and an issue to handle verification throttling on the server side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. This is ready to merge.
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR adds the phone number verification for new and existing MOD UI users when they enter a new phone number for trip notifications. The is a little bit different than in original mockups but for now it is a single flow that works for both new and existing users.
UPDATE: commit ibi-group/otp-middleware@5621a13 or equivalent is required.UPDATE: commit ibi-group/otp-middleware@a9386a6 or equivalent is required.
UPDATE: there
is aare new configuration parameters for:This PR depends on
ibi-group/otp-middleware#33ibi-group/otp-middleware#83 (remember to add the Twilio SMS service config variable to the middleware)and implements a workaround for this issue.