Add more memory for docker container [ci skip] #6105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
changed the title
doc/user/Container-Image.md
Outdated
| docker run --rm -v "$(pwd)/berlin:/var/opentripplanner" docker.io/opentripplanner/opentripplanner:latest --build --save | ||
| docker run --rm \ | ||
| --memory=8g \ | ||
| -e JAVA_OPTS='-Xmx8g' \ |
There was a problem hiding this comment.
I know it's common but a few paragraphs down we say that we want to use JAVA_TOOL_OPTIONS. I might remove support for JAVA_OPTS in the future.
doc/user/Container-Image.md
Outdated
| @@ -20,9 +20,16 @@ curl -L https://download.geofabrik.de/europe/germany/berlin-latest.osm.pbf -o be | |||
| # download GTFS | |||
| curl -L https://vbb.de/vbbgtfs -o berlin/vbb-gtfs.zip | |||
| # build graph and save it onto the host system via the volume | |||
| docker run --rm -v "$(pwd)/berlin:/var/opentripplanner" docker.io/opentripplanner/opentripplanner:latest --build --save | |||
| docker run --rm \ | |||
| --memory=8g \ | |||
There was a problem hiding this comment.
Suggested change
| --memory=8g \ |
This actually limits the memory rather than increasing it.
doc/user/Container-Image.md
Outdated
| # load and serve graph | ||
| docker run -it --rm -p 8080:8080 -v "$(pwd)/berlin:/var/opentripplanner" docker.io/opentripplanner/opentripplanner:latest --load --serve | ||
| docker run -it --rm -p 8080:8080 \ | ||
| --memory=8g \ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6105 +/- ##
=============================================
- Coverage 69.84% 69.84% -0.01%
Complexity 17463 17463
=============================================
Files 1974 1974
Lines 74606 74606
Branches 7640 7640
=============================================
- Hits 52109 52108 -1
Misses 19850 19850
- Partials 2647 2648 +1 ☔ View full report in Codecov by Sentry. |
|
this is fixed. I highly recommend keeping my change as new users will inevitably error out with not enough heap space |
leonardehrenfried
approved these changes
Oct 3, 2024
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Docker memory command line parameters to ensure that it does not error out due to lack of memory.