Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switchable debug tiles for new UI #5624

Merged

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Jan 15, 2024

Summary

This iteration adds switchable debug layers for edges to the Debug UI.

image

I expect there to be many more iterations where we add more layers, styles and information to help debugging.

I also implemented an automatic pan to the area defined by the world envelope service.

Issue

#5330

Unit tests

Updated.

@leonardehrenfried leonardehrenfried added the OTP Debug UI The OTP bundled client label Jan 15, 2024
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner January 15, 2024 10:46
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (31896ea) 67.55% compared to head (f1a9be0) 67.57%.
Report is 41 commits behind head on dev-2.x.

Files Patch % Lines
.../vectortiles/GraphInspectorVectorTileResource.java 0.00% 15 Missing ⚠️
...lanner/inspector/vector/edge/EdgeLayerBuilder.java 0.00% 12 Missing ⚠️
...er/inspector/vector/vertex/VertexLayerBuilder.java 0.00% 11 Missing ⚠️
...nner/inspector/vector/edge/EdgePropertyMapper.java 0.00% 9 Missing ⚠️
.../inspector/vector/vertex/VertexPropertyMapper.java 0.00% 9 Missing ⚠️
...ipplanner/apis/vectortiles/model/StyleBuilder.java 91.42% 4 Missing and 2 partials ⚠️
...ntripplanner/apis/vectortiles/model/LayerType.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5624      +/-   ##
=============================================
+ Coverage      67.55%   67.57%   +0.02%     
- Complexity     16224    16244      +20     
=============================================
  Files           1865     1872       +7     
  Lines          71204    71356     +152     
  Branches        7398     7406       +8     
=============================================
+ Hits           48104    48221     +117     
- Misses         20607    20637      +30     
- Partials        2493     2498       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried changed the title Switchable debug tiles for new Debug UI Switchable debug tiles for new UI Jan 15, 2024
Copy link
Member

@abyrd abyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Chrome 120.0.6099.216 (arm64) and Safari 17.1 (19616.2.9.11.7). Selection and display of layers works as described. My review of the source code was relatively superficial but it looks good overall.

@t2gran t2gran added this to the 2.5 (next release) milestone Jan 17, 2024
@leonardehrenfried leonardehrenfried merged commit 9b8fec2 into opentripplanner:dev-2.x Jan 18, 2024
6 checks passed
@leonardehrenfried leonardehrenfried deleted the vector-edges branch January 18, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OTP Debug UI The OTP bundled client Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants