Include images into vite build process so urls are transformed correctly #5579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5579 +/- ##
==========================================
Coverage 67.35% 67.35%
Complexity 16150 16150
==========================================
Files 1857 1857
Lines 71075 71075
Branches 7402 7402
==========================================
Hits 47872 47872
Misses 20745 20745
Partials 2458 2458 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
approved these changes
Dec 18, 2023
optionsome
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves images from public folder into src and uses imports to allow Vite to transform URLs. Note that some images are bundled into the transpiled code as data urls, since they are very small (most of the mode icons).
This PR would be a prerequisite for #5578 to work correctly with images.
Issue
#5330