Apply review feedback

opentripplanner · Mar 12, 2024 · ba8e563 · ba8e563
1 parent 3b80bf2
commit ba8e563
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/docs/Migrating-Configuration.md b/docs/Migrating-Configuration.md
@@ -29,7 +29,7 @@ risk - even if the environment changed.
 ### Aborting on invalid configuration
 
 If you want OTP to abort the startup when encountering unknown configuration parameters, you can add 
-the flag `--configCheck` to your regular OTP CLI commands.
+the flag `--abortOnUnknownConfig` to your regular OTP CLI commands.
 
 This should of course be used wisely as it can also accidentally make your production instances refuse 
 to start up.

diff --git a/mkdocs.yml b/mkdocs.yml
@@ -76,7 +76,7 @@ nav:
     - Router: 'RouterConfiguration.md'
     - "Route Request": 'RouteRequest.md'
     - "Realtime Updaters": 'UpdaterConfig.md'
-    - "Migrating Configuration": 'Migrating-Configuration.md'
+    - "Migrating between versions/builds": 'Migrating-Configuration.md'
 - Features explained:
     - "Routing modes": 'RoutingModes.md'
     - "In-station navigation": 'In-Station-Navigation.md'

diff --git a/src/main/java/org/opentripplanner/standalone/OTPMain.java b/src/main/java/org/opentripplanner/standalone/OTPMain.java
@@ -180,10 +180,10 @@ private static void startOTPServer(CommandLineParameters cli) {
    * Optionally, check if the config is valid and if not abort the startup process.
    */
   private static void detectUnusedConfigParams(CommandLineParameters cli, ConfigModel config) {
-    if (cli.configCheck && config.hasIUnknownProperties()) {
+    if (cli.abortOnUnknownConfig && config.hasUnknownProperties()) {
       throw new OtpAppException(
         "Configuration contains invalid properties (see above for details). " +
-        "Please fix your configuration or remove --configCheck from your OTP CLI parameters."
+        "Please fix your configuration or remove --abortOnUnknownConfig from your OTP CLI parameters."
       );
     }
   }

diff --git a/src/main/java/org/opentripplanner/standalone/config/CommandLineParameters.java b/src/main/java/org/opentripplanner/standalone/config/CommandLineParameters.java
@@ -134,10 +134,10 @@ public class CommandLineParameters {
   public boolean visualize;
 
   @Parameter(
-    names = { "--configCheck" },
+    names = { "--abortOnUnknownConfig" },
     description = "Abort the startup if configuration files are found to be invalid."
   )
-  public boolean configCheck = false;
+  public boolean abortOnUnknownConfig = false;
 
   /**
    * The remaining single parameter after the switches is the directory with the configuration

diff --git a/src/main/java/org/opentripplanner/standalone/config/ConfigModel.java b/src/main/java/org/opentripplanner/standalone/config/ConfigModel.java
@@ -109,7 +109,7 @@ public static void initializeOtpFeatures(OtpConfig otpConfig) {
   /**
    * Checks if any unknown or invalid properties were encountered while loading the configuration.
    */
-  public boolean hasIUnknownProperties() {
+  public boolean hasUnknownProperties() {
     return (
       otpConfig.hasUnknownProperties() ||
       buildConfig.hasUnknownProperties() ||