This repository has been archived by the owner on May 23, 2023. It is now read-only.
Move to the immutable SpanContext model #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return this Span instance, for chaining | ||
| */ | ||
| Span setBaggageItem(String key, String value); |
There was a problem hiding this comment.
(this pair is of course moved from SpanContext)
|
LGTM |
|
@yurishkuro thanks. I will let this one sit for a little bit to give others an opportunity to protest about method naming/etc. (Though the gist of the change is something I feel confident about, nits aside) |
|
This causes PR#25 some conflict (i've already had to rebase it twice) Otherwise it looks good.. |
|
@michaelsembwever sorry for the rebase thrashing :-/ Well, there were no concerns with the actual code, so I'll get to merging this. Thanks, all. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per opentracing/opentracing.io#106
This change has already happened in Go and Python.