This repository has been archived by the owner on May 23, 2023. It is now read-only.
Document GlobalTracer in opentracing-util #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhs Any chance of this getting merged? I thought a add-README PR wouldn't be a big deal, but didn't want to nag you since you were on more important matters 😉 |
bhs
reviewed
May 11, 2017
opentracing-util/README.md
Outdated
| Once initialized, all application code can instrument tracing by starting new spans like: | ||
|
|
||
| ```java | ||
| try (Span span = GlobalTracer.get().buildSpan("someOperation").start()) { |
There was a problem hiding this comment.
Since #115 is in, I guess we ought to use startActive() in examples... feels a little premature, but better to be consistent at master.
There was a problem hiding this comment.
Totally agree about this one.
|
@sjoerdtalsma sorry for the delay, I missed this entirely. I have the one nit but otherwise LGTM. |
|
... and nagging me is always fine (encouraged, actually). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
opentracing-contrib/java-globaltracerrepo had a README explaining the GlobalTracer.Although the JavaDoc was moved along with the code to
opentracing-util, the README hadn't yet been copied.