This repository has been archived by the owner on May 23, 2023. It is now read-only.
Add support to GlobalTracer to indicate if a tracer has been registered #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Nov 29, 2018
|
I am trying to fix the build in #202 |
|
please rebase off master to fix the build. also, please add a unit test. |
|
@yurishkuro I've added unit tests for GlobalTracer |
MikeGoldsmith
force-pushed
the
registered-global-tracer
branch
from
b12a8d2
to
0a9f187
Compare
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 58.74% 59.32% +0.58%
==========================================
Files 14 14
Lines 829 831 +2
==========================================
+ Hits 487 493 +6
+ Misses 302 298 -4
Partials 40 40
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Nov 29, 2018
|
@austinlparker second pair of eyes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to identify if the global tracer is using the default NoopTracer or has had a tracer registered. This is useful for integration libraries to determine if they can/should set a tracer or use the configured global tracer.
This was first discussed in opentracing/opentracing-csharp#113