Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targets netstandard1.0 and net45 and updates build infrastructure to latest .NET Core SDK #56

Merged
merged 2 commits into from
Feb 7, 2018

Conversation

cwe1ss
Copy link
Member

@cwe1ss cwe1ss commented Feb 3, 2018

This PR does two things:

  • Builds now require the latest .NET Core SDK (2.1.4). This is enforced in the new global.json
    • dotnet restore is now an implicit operation in dotnet build so it's no longer required
  • The OpenTracing library now also targets "net45" which was requested in Target both netstandard1.0 and net45 to remove unneeded dependencies #51. The code in this PR doesn't require a separate msbuild parameter though.

Since this doesn't contain any functional changes, I will only wait until Monday or Tuesday to merge it -
unless there's contrary feedback of course.

@cwe1ss cwe1ss added this to the 0.11.0 milestone Feb 3, 2018
@cwe1ss cwe1ss merged commit 159e318 into master Feb 7, 2018
@cwe1ss cwe1ss deleted the cweiss/build branch February 7, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant