Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements for PR #1 #2

Merged
merged 53 commits into from
Aug 31, 2016
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
e6392b6
Initial commit
dawallin May 26, 2016
26ce53e
Changed License to MIT
dawallin May 26, 2016
05e3379
.gitignore for visual studio project
dawallin May 26, 2016
5a7a752
Readme file added.
dawallin May 26, 2016
1a956bc
OpenTracing initial commit
dawallin May 26, 2016
e096e40
BasicTracer initial commit
dawallin May 26, 2016
f80f893
HttpClientCarrair initial commit
dawallin May 26, 2016
c2df056
Build status in readme
dawallin May 26, 2016
e0939a1
Removed SpanFactory
dawallin May 30, 2016
a5334d4
Removed SpanRecorder
dawallin May 30, 2016
9571514
Renamed BasicTracerContext to OpenTracingSpanContext (from BasicSpanC…
dawallin May 31, 2016
b90961a
Moved Tracer and Span implementations to BasicTracer (from OpenTracin…
dawallin May 31, 2016
d570a6a
Removed leaking context in StartSpanOptions.Parent.
dawallin May 31, 2016
b4387e5
Moved the OpenTracing Tracer and Span to root namespace.
dawallin Jun 1, 2016
6b0eb32
Moved the BasicTracer Tracer and Span to root namespace
dawallin Jun 1, 2016
8ff3c6c
Fixed unit test name (from copy paste typo error).
dawallin Jun 1, 2016
583e0df
Changed assembly name to simply OpenTracing.dll
dawallin Jun 2, 2016
668dfd4
Nuspec:s for OpenTracing and BasicTracer
dawallin Jun 2, 2016
af55c33
Clean up some namespaces.
dawallin Jun 2, 2016
5d4c4b9
Removed many generic type constraints on interfaces not needed.
dawallin Jun 4, 2016
68e7316
Moved TracerBuilder to BasicTracer
dawallin Jun 4, 2016
72a26c4
Moved SpanContext interfaces out from OpenTracing into BasicTracer.
dawallin Jun 4, 2016
2951da2
Simplified ContextMapper and removed TextMapFormat
dawallin Jun 5, 2016
97de99e
Merge branch 'InitialPR' into master
dawallin Jun 6, 2016
6656848
build script; rename to src (to better follow new Microsoft repos)
cwe1ss Aug 20, 2016
c253d97
since parent folder is now called "src", library folder can be "OpenT…
cwe1ss Aug 20, 2016
7189a71
nuget.exe not necessary with dotnet cli
cwe1ss Aug 20, 2016
094de2c
converted netstandard
cwe1ss Aug 20, 2016
435216f
refactoring
cwe1ss Aug 20, 2016
1e2352d
refactoring
cwe1ss Aug 20, 2016
ce43aa5
abstract base class for Span, singleton for NullTracer
cwe1ss Aug 20, 2016
d2d8ea8
SetTag now accepts an object
cwe1ss Aug 20, 2016
3f573ca
built-in tags are now regular ISpan extensions; BasicTracer compiles
cwe1ss Aug 21, 2016
705dec5
API refinements
cwe1ss Aug 21, 2016
1e6e7e2
tests succeed
cwe1ss Aug 21, 2016
ab72020
separate files for interfaces
cwe1ss Aug 21, 2016
62a4bdc
move tests to test folder
cwe1ss Aug 21, 2016
e532779
renamed IntegrationTests project to just tests
cwe1ss Aug 21, 2016
3f4c0b3
moved baggage dictionary into its own class
cwe1ss Aug 21, 2016
65885ee
removed SpanContext.GetBaggageItems() from interface
cwe1ss Aug 21, 2016
b79bb3c
naming etc
cwe1ss Aug 21, 2016
dc9c8fd
visual studio files
cwe1ss Aug 21, 2016
a29b4bd
stuff that accepts ISpanContext now also accepts ISpan
cwe1ss Aug 21, 2016
317f958
accidentally commited sample code; fixed powershell warnings
cwe1ss Aug 21, 2016
5db8b2d
PoC for AspNetCore integration
cwe1ss Aug 21, 2016
e052b65
big refactoring after gitter discussion; docs
cwe1ss Aug 23, 2016
5ea4551
renamed Log() to LogEvent() as of https://github.com/opentracing/open…
cwe1ss Aug 23, 2016
7d2cca2
TODOs
cwe1ss Aug 23, 2016
d39266a
removed get/setBaggageItem from SpanContext - as of opentracing.githu…
cwe1ss Aug 24, 2016
f4f1488
SpanBuilder from @dawallin
cwe1ss Aug 24, 2016
8c25747
SetOperationName(), BasicTracer: removed baggage key restrictions
cwe1ss Aug 29, 2016
e9c8ae8
Format/Carrier now almost equal to Java implementation
cwe1ss Aug 29, 2016
f55fdd6
AspNetCore is now in a separate branch - will move to a different rep…
cwe1ss Aug 29, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
renamed Log() to LogEvent() as of opentracing/opentracing.io#26
  • Loading branch information
cwe1ss committed Aug 23, 2016
commit 5ea45519461f6c61e6ed8c9e3ccb1159b8d2c6b9
4 changes: 2 additions & 2 deletions src/OpenTracing/ISpan.cs
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@ public interface ISpan : IDisposable
/// <param name="eventName">Name of the event.</param>
/// <param name="payload">An optional payload object.</param>
/// <returns>The current <see cref="ISpan"/> instance for chaining.</returns>
ISpan Log(string eventName, object payload = null);
ISpan LogEvent(string eventName, object payload = null);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just FYI, logging is a bit of a moving target right now... I'm going to make some progress on opentracing/opentracing.io#96 today or this weekend.


/// <summary>
/// Records an event with optional payload data for this Span.
@@ -45,7 +45,7 @@ public interface ISpan : IDisposable
/// <param name="eventName">Name of the event.</param>
/// <param name="payload">An optional payload object.</param>
/// <returns>The current <see cref="ISpan"/> instance for chaining.</returns>
ISpan Log(DateTimeOffset timestamp, string eventName, object payload = null);
ISpan LogEvent(DateTimeOffset timestamp, string eventName, object payload = null);

/// <summary>
/// <para>Sets a baggage item in the Span (and its SpanContext) as a key/value pair.</para>
4 changes: 2 additions & 2 deletions src/OpenTracing/NullTracer/NullSpan.cs
Original file line number Diff line number Diff line change
@@ -18,12 +18,12 @@ public ISpan SetTag(string key, object value)
return this;
}

public ISpan Log(string eventName, object payload = null)
public ISpan LogEvent(string eventName, object payload = null)
{
return this;
}

public ISpan Log(DateTimeOffset timestamp, string eventName, object payload = null)
public ISpan LogEvent(DateTimeOffset timestamp, string eventName, object payload = null)
{
return this;
}