Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target netstandard1.3 and net45 #62

Closed
cwe1ss opened this issue Feb 10, 2018 · 5 comments
Closed

Target netstandard1.3 and net45 #62

cwe1ss opened this issue Feb 10, 2018 · 5 comments
Labels
breaks-instrumentation A breaking change for users of the OpenTracing API breaks-tracers A breaking change for tracers
Milestone

Comments

@cwe1ss
Copy link
Member

cwe1ss commented Feb 10, 2018

I'd like to make sure people don't do weird stuff with this library unless we know about it. One way to ensure this is to only target officially supported versions of .NET Core and the full .NET framework.

We currently target netstandard1.0 but this also includes stuff like Silverlight and Windows Phone, which are no longer supported by Microsoft.

For this reason, I'd like to target netstandard1.3 (which supports .NET Core 1+, .NET 4.6+, Xamarin, Mono, UWP) and net452 to support .NET 4.5.2 (which is the only officially supported .NET 4.5 version)

See .NET Standard for details.

If people really need it for older platforms, we can always talk about it and loosen this requirement - it's always easier to add older targets than to remove them.

Edit 2018-02-20: We are using net45 instead of net452 (see comments)

@cwe1ss cwe1ss added this to the 0.11.0 milestone Feb 10, 2018
@cwe1ss
Copy link
Member Author

cwe1ss commented Feb 10, 2018

@bmermet @ndrwrbgs you've said in #51 that you're targeting .NET 4.5 at work. Are you targeting .NET 4.5.2 or an older version? (Note that older versions are no longer supported by Microsoft)

@cwe1ss
Copy link
Member Author

cwe1ss commented Feb 13, 2018

I've committed this change with #63. Feel free to comment here if that's a problem... we can easily change that.

@MikeGoldsmith
Copy link
Member

I think we should target net45 too. It's still listed as part of the compatibility matrix on the MS documentation pages and because we fall back to CallContext when using < net462 (AsyncLocal not available) we're still covered.

I would also require it as part of my integration with Couchbase SDK as we currently target net45, netstandard1.3 and netstandard2.0. As an integration library, we're not in control of what framework version our customers use.

cwe1ss added a commit that referenced this issue Feb 20, 2018
@cwe1ss
Copy link
Member Author

cwe1ss commented Feb 20, 2018

I changed it to net45 instead of net452.

@cwe1ss cwe1ss changed the title Target netstandard1.3 and net452 Target netstandard1.3 and net45 Feb 20, 2018
@cwe1ss
Copy link
Member Author

cwe1ss commented Mar 1, 2018

I've just released v0.11.0. Please create a new issue with your scenario if you need support for lower .NET Standard versions.

@cwe1ss cwe1ss closed this as completed Mar 1, 2018
@cwe1ss cwe1ss added breaks-instrumentation A breaking change for users of the OpenTracing API breaks-tracers A breaking change for tracers and removed breaking-change labels Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks-instrumentation A breaking change for users of the OpenTracing API breaks-tracers A breaking change for tracers
Projects
None yet
Development

No branches or pull requests

2 participants