This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Add JSON support to the mock tracer. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into mocktracer
|
@isaachier -- look ok? |
isaachier
approved these changes
Jan 22, 2018
| BEGIN_OPENTRACING_ABI_NAMESPACE | ||
| namespace mocktracer { | ||
| // Serialize provided spans to JSON. | ||
| std::string ToJson(const std::vector<SpanData>& spans); |
There was a problem hiding this comment.
If you want better nlohmann/JSON support, put this in the nlohmann namespace as described in the docs there. That allows for native conversion to/from JSON types.
There was a problem hiding this comment.
Never mind see you did it later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for serializing/deserializing mock spans to/from JSON.
This will be useful for testing dynamic loading scenarios where there is no direct access to the InMemoryRecorder API.