-
Notifications
You must be signed in to change notification settings - Fork 328
fix(select): [select] Adapt to multiple+disabled+displayOnly scenarios with different themes #1885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s with different themes
WalkthroughThe recent changes introduce new computed properties and methods in the component's code, enhancing its functionality. Specifically, the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/design/saas/src/select/index.ts (1 hunks)
Additional comments not posted (2)
packages/design/saas/src/select/index.ts (2)
93-95
: LGTM!The
computedShowTagText
function correctly determines the visibility of tags based onisDisabled
orisDisplayOnly
states.
97-98
: LGTM!The
isTagClosable
function correctly prevents the closing of tags that are marked as required.
…s with different themes
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit