Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Correction of port number in Chinese and English README and contribution guide documents, as well as WeChat correction of mini assistant in Issue template #171

Merged
merged 1 commit into from
Apr 23, 2023
Merged

docs: Correction of port number in Chinese and English README and contribution guide documents, as well as WeChat correction of mini assistant in Issue template #171

merged 1 commit into from
Apr 23, 2023

Conversation

heygsc
Copy link
Contributor

@heygsc heygsc commented Apr 22, 2023 •
edited
Loading

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 167，168

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This was referenced Apr 22, 2023
Closed
Closed
@heygsc heygsc changed the title fix：readme文档的端口号的改动，以及issue模板的微信号的改动 fix：readme文档和贡献文档的端口号的改动，以及issue模板的微信号的改动 Apr 22, 2023
@heygsc heygsc changed the title fix：readme文档和贡献文档的端口号的改动，以及issue模板的微信号的改动 fix：中英文README和中英文贡献指南文档中的本地启动端口号的修正，以及Issue 模板中的小助手微信号错误 Apr 22, 2023
@heygsc heygsc changed the title fix：中英文README和中英文贡献指南文档中的本地启动端口号的修正，以及Issue 模板中的小助手微信号错误 fix：中英文README文档和贡献指南文档的端口号的修正，以及Issue模板中的小助手微信号修正 Apr 22, 2023
@heygsc heygsc changed the title fix：中英文README文档和贡献指南文档的端口号的修正，以及Issue模板中的小助手微信号修正 fix：中英文README和贡献指南文档中端口号的修正，以及Issue模板中的小助手微信号修正 Apr 22, 2023
@kagol kagol added the documentation Improvements or additions to documentation label Apr 22, 2023
kagol
kagol previously approved these changes Apr 22, 2023
View reviewed changes
@kagol
Copy link
Member

kagol commented Apr 22, 2023

@heygsc 你这个 PR 主要有以下几个问题：

  1. commit message 信息不符合规范，如果是修改文档的话，应该是以docs: 为前缀，比如：docs: 修正 README 和贡献指南中本地启动的端口号
  2. commit 记录不应该有6条，而是1条，请使用 git rebase 命令将 commit 记录进行合并操作
  3. 你的提交没有做 GPG 签名，请参考文档：https://insights.thoughtworks.cn/how-to-sign-git-commit/

@heygsc heygsc changed the title fix：中英文README和贡献指南文档中端口号的修正，以及Issue模板中的小助手微信号修正 docs：中英文README和贡献指南文档中端口号的修正，以及Issue模板中的小助手微信号修正 Apr 22, 2023
@heygsc
Copy link
Contributor Author

heygsc commented Apr 22, 2023 •
edited
Loading

@kagol ok，我改了一下

@zzcr zzcr merged commit 9932230 into opentiny:dev Apr 23, 2023
@heygsc heygsc deleted the port branch May 4, 2023 16:18
@heygsc
Copy link
Contributor Author

heygsc commented May 14, 2023

@all-contributors please add @heygsc for code

@allcontributors allcontributors bot mentioned this pull request May 14, 2023
Merged
@allcontributors
Copy link
Contributor

@heygsc

I've put up a pull request to add @heygsc! 🎉

@kagol kagol changed the title docs：中英文README和贡献指南文档中端口号的修正，以及Issue模板中的小助手微信号修正 docs: Correction of port number in Chinese and English README and contribution guide documents, as well as WeChat correction of mini assistant in Issue template Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzcr zzcr zzcr approved these changes

@kagol kagol kagol left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heygsc @kagol @zzcr