fix: fix app param type error when create group

[gene9831]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

现象：开启mergeCategoriesAndGroups功能后，在区块管理创建分组时，出现错误：app should be a string。

根因：创建分类接口的app参数是Number，创建分组接口的app参数是String，接口直接替换导致了错误。
解决方案：调用创建分组接口时，不将appId转换成字符串

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Bug Fixes
  • Improved logic for handling category and group creation/update processes
  • Enhanced request function selection based on specific operation conditions

[coderabbitai]

Walkthrough

The pull request modifies the createOrUpdateCategory function in the blockSetting.jsx file, focusing on improving the logic for handling category and group assignments. The changes refine how the params.app is set and how the request function is determined based on the replaceCategoryWithGroup condition. The modifications aim to provide more explicit and precise handling of category and group operations, ensuring the correct request function is used depending on the specific context of the operation.

Changes

File	Change Summary
packages/plugins/block/src/js/blockSetting.jsx	Updated logic for createOrUpdateCategory function, including more precise handling of params.app assignment and requestFunc selection based on replaceCategoryWithGroup condition

Possibly related PRs

• feat: Support merging categories and groups #907: Changes involving merging categories and groups, directly related to the modifications in the createOrUpdateCategory function

Suggested labels

enhancement

Suggested reviewers

• hexqi

Poem

🐰 A rabbit's tale of code so bright,
Where categories dance with groups just right,
Params and functions, now crystal clear,
Logic refined without a fear,
In the realm of blocks, precision takes flight! 🔧

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/plugins/block/src/js/blockSetting.jsx (1)

731-732: Consider using a single declaration style for consistency.

Currently, requestFunc is declared with let here, but the same variable is reused in subsequent conditionals. This is fine, but if you plan to reassign it multiple times, ensure that it’s well-documented that requestFunc can change across the different branch conditions. Otherwise, consider separating the logic if clarity becomes an issue.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9027902 and 7eeeaa2.

📒 Files selected for processing (1)

• packages/plugins/block/src/js/blockSetting.jsx (1 hunks)

🔇 Additional comments (2)

packages/plugins/block/src/js/blockSetting.jsx (2)

733-739: Validate numeric conversion of appId.

When replaceCategoryWithGroup is false, params.app is assigned Number(appId). If appId cannot be safely converted, Number(appId) may produce NaN. Verify upstream code ensures appId is a valid numeric string or handle parse exceptions gracefully.

---

742-746: Confirm consistency for newly created “group” vs. “category”.

When creating a new category, params.category_id is set to categoryId. In a scenario with replaceCategoryWithGroup = true, consider if a similar parameter is needed for creating a group (e.g., group_id) or if it is intentionally omitted.

Do you need any help confirming whether the “createGroup” API requires a group identifier similar to category_id?