Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send staking and unstaking fees to SubnetTAO #1176

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

gztensor
Copy link
Contributor

@gztensor gztensor commented Jan 21, 2025

Description

add_stake, remove_stake, and move_stake will capture fees from the TAO being staked / unstaked. The fee amount will be 500k rao (using DefaultMinStake value).

Validation will be filtering out add_stake transactions if amount to be staked or account balance to fulfill the fee is insufficient.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

sam0x17
sam0x17 previously approved these changes Jan 21, 2025
@gztensor gztensor marked this pull request as ready for review January 22, 2025 00:23
@gztensor gztensor requested a review from unconst as a code owner January 22, 2025 00:23
@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jan 22, 2025
@gztensor gztensor requested a review from sam0x17 January 22, 2025 00:23
@sam0x17 sam0x17 force-pushed the feat/add-staking-tx-fees-to-subnet-tao branch from 61baae1 to a516c2b Compare January 22, 2025 02:46
@gztensor gztensor requested a review from camfairchild January 22, 2025 18:24
@sam0x17 sam0x17 merged commit ecb6196 into devnet-ready Jan 22, 2025
11 of 15 checks passed
This was referenced Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants