Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin utils benchmarks #1092

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

ales-otf
Copy link
Contributor

@ales-otf ales-otf commented Dec 12, 2024

Description

In #1084 I made a mistake in benchmarking forgetting to import Vec from alloc (which is not available in no_std). This PR fixes it.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@github-actions github-actions bot added the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Dec 12, 2024
@ales-otf ales-otf changed the base branch from main to devnet-ready December 12, 2024 15:34
@opentensor opentensor deleted a comment from github-actions bot Dec 12, 2024
@ales-otf ales-otf added no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway and removed hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet labels Dec 12, 2024
@ales-otf ales-otf marked this pull request as ready for review December 12, 2024 15:35
@ales-otf ales-otf requested a review from unconst as a code owner December 12, 2024 15:35
@sam0x17 sam0x17 merged commit a2a9bbb into devnet-ready Dec 13, 2024
25 of 27 checks passed
@ales-otf ales-otf deleted the fix/admin-utils-benchmarks branch December 13, 2024 15:01
This was referenced Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants