Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pending childkeys #1050

Merged
merged 13 commits into from
Dec 6, 2024
Merged

Feat/pending childkeys #1050

merged 13 commits into from
Dec 6, 2024

Conversation

gztensor
Copy link
Contributor

@gztensor gztensor commented Dec 3, 2024

Description

Pending children. See description in issue #1041

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

The behavior of set_children changes: Instead of setting children immediately, the children will be set in the subnet epoch after a cool down period (7200 blocks).

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

n/a

Additional Notes

n/a

@gztensor gztensor marked this pull request as ready for review December 3, 2024 01:08
@gztensor gztensor requested a review from unconst as a code owner December 3, 2024 01:08
Copy link
Contributor

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise looks good

@gztensor gztensor requested a review from camfairchild December 3, 2024 17:09
camfairchild
camfairchild previously approved these changes Dec 3, 2024
camfairchild
camfairchild previously approved these changes Dec 3, 2024
This reverts commit 796ffdb.
@gztensor gztensor added the no-spec-version-bump PR does not contain changes that requires bumping the spec version label Dec 4, 2024
@gztensor gztensor requested a review from camfairchild December 4, 2024 00:06
camfairchild
camfairchild previously approved these changes Dec 4, 2024
@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Dec 4, 2024
@gztensor gztensor requested a review from camfairchild December 4, 2024 17:50
camfairchild
camfairchild previously approved these changes Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants