Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: dont payout if reg disabled #1024

Merged
merged 11 commits into from
Nov 27, 2024
Merged

hotfix: dont payout if reg disabled #1024

merged 11 commits into from
Nov 27, 2024

Conversation

distributedstatemachine
Copy link
Collaborator

Description

This PR fixes a regression where subnets are still being paid out when registrations are turned off

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@github-actions github-actions bot added the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

🚨🚨🚨 HOTFIX DETECTED 🚨🚨🚨

It looks like you are trying to merge a hotfix PR into . If this isn't what you wanted to do, and you just wanted to make a regular PR, please close this PR, base your changes off the branch and open a new PR into .

If you are trying to merge a hotfix PR, please complete the following essential steps:

  1. go ahead and get this PR into main merged, so we can get the change in as quickly as possible!
  2. merge main into testnet, bumping spec_version
  3. deploy testnet
  4. merge testnet into devnet, bumping spec_version
  5. deploy devnet
  6. merge devnet into devnet-ready

If you do not complete these steps, your hotfix may be inadvertently removed in the future when branches are promoted to main, so it is essential that you do so.

Copy link
Contributor

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be or. We want to skip for both netuid 0 OR reg not allowed

pallets/subtensor/src/coinbase/run_coinbase.rs Outdated Show resolved Hide resolved
pallets/subtensor/src/coinbase/run_coinbase.rs Outdated Show resolved Hide resolved
Co-authored-by: Cameron Fairchild <cameron@opentensor.ai>
Co-authored-by: Cameron Fairchild <cameron@opentensor.ai>
@unconst unconst merged commit 44d6859 into main Nov 27, 2024
@distributedstatemachine distributedstatemachine deleted the hotfix/reg_disabled_payouts branch November 27, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants