Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] [BIT 578] speed up metagraph storage query #933
[feature] [BIT 578] speed up metagraph storage query #933
Changes from 21 commits
84b290c
95e254d
95ee66c
9614b8f
c776224
d1bf728
221bc64
d6a3ba1
1cc692d
5e07a11
475ac28
e069441
f0d1290
ca97998
63fe7d3
ea1f346
c5f4b91
80f8867
a9b45af
18f422b
bfd9d87
f53fca4
e989b61
2327aa9
0b0e48c
711f847
28e3ac6
10ccc0a
95febf1
83d204b
1a19ab3
d52b2cc
2c686ac
f24f5bd
f66a16d
761356a
31a7b8e
3cdb226
e3dc85e
5c5903f
4c4ddbc
f2d4046
6d41dc0
c88d1e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is helpful given that you are including an external binary.
What about moving this specification to a document in the bin file and translate this comment also to a set of unit tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both documents; the specification and the tests could be referenced here with links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding unit tests for the binary file is good to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, @camfairchild this should be moved to a proper documentation as well. Nicely done!