Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using prompt in SDK #2382

Merged
merged 11 commits into from
Nov 5, 2024

Conversation

roman-opentensor
Copy link
Contributor

@roman-opentensor roman-opentensor commented Nov 5, 2024

SDK is intended for use in Python scripts and does not provide for interactive things. Due to this it was decided to avoid using the prompt flag and the prompt argument.

Tests are updated.

@roman-opentensor roman-opentensor self-assigned this Nov 5, 2024
@roman-opentensor roman-opentensor added enhancement New feature or request bittensor labels Nov 5, 2024
@roman-opentensor roman-opentensor requested a review from a team November 5, 2024 04:31
@thewhaleking thewhaleking self-requested a review November 5, 2024 16:43
Copy link
Contributor

@ibraheem-opentensor ibraheem-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few tiny nits

@roman-opentensor roman-opentensor changed the title Avoid using promt in SDK Avoid using prompt in SDK Nov 5, 2024
@roman-opentensor roman-opentensor mentioned this pull request Nov 5, 2024
2 tasks
@ibraheem-opentensor ibraheem-opentensor merged commit 3e1e179 into staging Nov 5, 2024
23 checks passed
@ibraheem-opentensor ibraheem-opentensor deleted the feat/roman/remove-prompt-from-sdk branch November 5, 2024 19:57
ibraheem-opentensor added a commit that referenced this pull request Nov 6, 2024
This was referenced Nov 6, 2024
roman-opentensor added a commit that referenced this pull request Nov 13, 2024
* Expands the type registry to include all the available options (#2353)

Expands the type registry to include all the available options

* add `Subtensor.register`, `Subtensor.difficulty` and related staff with tests (#2352)

* add `bittensor.core.subtensor.Subtensor.register`, `bittensor.core.subtensor.Subtensor.difficulty` and related staff with tests

* remove commented code

* update `_terminate_workers_and_wait_for_exit` by review

* added to Subtensor: `burned_register`, `get_subnet_burn_cost`, `recycle` and related extrinsics (#2359)

* added to Subtensor: `burned_register`, `get_subnet_burn_cost`, `recycle` and related extrinsics

* formatter

* Update bittensor/core/extrinsics/registration.py

Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>

---------

Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>

* Poem "Risen from the Past". Act 3. (#2363)

* add `get_delegate_by_hotkey`, update `DelegateInfo` in chain data

* add `root_register_extrinsic`, `set_root_weights_extrinsic` and related stuff

* add `Subtensor.get_all_subnets_info` method and related stuff

* add `Subtensor.get_delegate_take` method and tests

* ruff

* remove unused import

* default port from 9946 to 9944 (#2376)

* remove unused prometheus extrinsic (#2378)

* Replace rich.console to btlogging.loggin (#2377)

* replace `rich.console` to `btlogging.logging`

* update requirements

* use whole path import

* fix some logging

* fix registration.py

* ruff

* del prometheus.py

* fix review comments

* Merge pull request #2382 from opentensor/feat/roman/remove-prompt-from-sdk

Avoid using `prompt` in SDK

* Handle SSL Error on Connection (#2384)

* Add `subvortex` subnet and tests (#2395)

* add `subvortex` subnet and tests

* ruff

* Bumps version and updates changelog

---------

Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>
Co-authored-by: ibraheem-opentensor <165814940+ibraheem-opentensor@users.noreply.github.com>
Co-authored-by: ibraheem-opentensor <ibraheem@opentensor.dev>
thewhaleking added a commit that referenced this pull request Nov 14, 2024
* Expands the type registry to include all the available options (#2353)

Expands the type registry to include all the available options

* add `Subtensor.register`, `Subtensor.difficulty` and related staff with tests (#2352)

* add `bittensor.core.subtensor.Subtensor.register`, `bittensor.core.subtensor.Subtensor.difficulty` and related staff with tests

* remove commented code

* update `_terminate_workers_and_wait_for_exit` by review

* added to Subtensor: `burned_register`, `get_subnet_burn_cost`, `recycle` and related extrinsics (#2359)

* added to Subtensor: `burned_register`, `get_subnet_burn_cost`, `recycle` and related extrinsics

* formatter

* Update bittensor/core/extrinsics/registration.py

Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>

---------

Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>

* Poem "Risen from the Past". Act 3. (#2363)

* add `get_delegate_by_hotkey`, update `DelegateInfo` in chain data

* add `root_register_extrinsic`, `set_root_weights_extrinsic` and related stuff

* add `Subtensor.get_all_subnets_info` method and related stuff

* add `Subtensor.get_delegate_take` method and tests

* ruff

* remove unused import

* default port from 9946 to 9944 (#2376)

* remove unused prometheus extrinsic (#2378)

* Replace rich.console to btlogging.loggin (#2377)

* replace `rich.console` to `btlogging.logging`

* update requirements

* use whole path import

* fix some logging

* fix registration.py

* ruff

* del prometheus.py

* fix review comments

* Merge pull request #2382 from opentensor/feat/roman/remove-prompt-from-sdk

Avoid using `prompt` in SDK

* Handle SSL Error on Connection (#2384)

* Add `subvortex` subnet and tests (#2395)

* add `subvortex` subnet and tests

* ruff

* Bumps version and updates changelog

* bumping up version

* Update CHANGELOG.md

* bumping version

* Update CHANGELOG.md

with 8.3.1

* update docker version in config.yml

* update docker version in config.yml

* remove docker job in config.yml

* remove docker job in config.yml 2

---------

Co-authored-by: Roman <167799377+roman-opentensor@users.noreply.github.com>
Co-authored-by: ibraheem-opentensor <165814940+ibraheem-opentensor@users.noreply.github.com>
Co-authored-by: ibraheem-opentensor <ibraheem@opentensor.dev>
Co-authored-by: Roman <roman@opentensor.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bittensor enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants