-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using prompt
in SDK
#2382
Merged
ibraheem-opentensor
merged 11 commits into
staging
from
feat/roman/remove-prompt-from-sdk
Nov 5, 2024
Merged
Avoid using prompt
in SDK
#2382
ibraheem-opentensor
merged 11 commits into
staging
from
feat/roman/remove-prompt-from-sdk
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prompt-from-sdk # Conflicts: # bittensor/core/async_subtensor.py # bittensor/core/extrinsics/async_root.py
ibraheem-opentensor
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a few tiny nits
2 tasks
Closed
ibraheem-opentensor
added a commit
that referenced
this pull request
Nov 6, 2024
…m-sdk Avoid using `prompt` in SDK
This was referenced Nov 6, 2024
Closed
Closed
Merged
roman-opentensor
added a commit
that referenced
this pull request
Nov 13, 2024
* Expands the type registry to include all the available options (#2353) Expands the type registry to include all the available options * add `Subtensor.register`, `Subtensor.difficulty` and related staff with tests (#2352) * add `bittensor.core.subtensor.Subtensor.register`, `bittensor.core.subtensor.Subtensor.difficulty` and related staff with tests * remove commented code * update `_terminate_workers_and_wait_for_exit` by review * added to Subtensor: `burned_register`, `get_subnet_burn_cost`, `recycle` and related extrinsics (#2359) * added to Subtensor: `burned_register`, `get_subnet_burn_cost`, `recycle` and related extrinsics * formatter * Update bittensor/core/extrinsics/registration.py Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com> --------- Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com> * Poem "Risen from the Past". Act 3. (#2363) * add `get_delegate_by_hotkey`, update `DelegateInfo` in chain data * add `root_register_extrinsic`, `set_root_weights_extrinsic` and related stuff * add `Subtensor.get_all_subnets_info` method and related stuff * add `Subtensor.get_delegate_take` method and tests * ruff * remove unused import * default port from 9946 to 9944 (#2376) * remove unused prometheus extrinsic (#2378) * Replace rich.console to btlogging.loggin (#2377) * replace `rich.console` to `btlogging.logging` * update requirements * use whole path import * fix some logging * fix registration.py * ruff * del prometheus.py * fix review comments * Merge pull request #2382 from opentensor/feat/roman/remove-prompt-from-sdk Avoid using `prompt` in SDK * Handle SSL Error on Connection (#2384) * Add `subvortex` subnet and tests (#2395) * add `subvortex` subnet and tests * ruff * Bumps version and updates changelog --------- Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com> Co-authored-by: ibraheem-opentensor <165814940+ibraheem-opentensor@users.noreply.github.com> Co-authored-by: ibraheem-opentensor <ibraheem@opentensor.dev>
thewhaleking
added a commit
that referenced
this pull request
Nov 14, 2024
* Expands the type registry to include all the available options (#2353) Expands the type registry to include all the available options * add `Subtensor.register`, `Subtensor.difficulty` and related staff with tests (#2352) * add `bittensor.core.subtensor.Subtensor.register`, `bittensor.core.subtensor.Subtensor.difficulty` and related staff with tests * remove commented code * update `_terminate_workers_and_wait_for_exit` by review * added to Subtensor: `burned_register`, `get_subnet_burn_cost`, `recycle` and related extrinsics (#2359) * added to Subtensor: `burned_register`, `get_subnet_burn_cost`, `recycle` and related extrinsics * formatter * Update bittensor/core/extrinsics/registration.py Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com> --------- Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com> * Poem "Risen from the Past". Act 3. (#2363) * add `get_delegate_by_hotkey`, update `DelegateInfo` in chain data * add `root_register_extrinsic`, `set_root_weights_extrinsic` and related stuff * add `Subtensor.get_all_subnets_info` method and related stuff * add `Subtensor.get_delegate_take` method and tests * ruff * remove unused import * default port from 9946 to 9944 (#2376) * remove unused prometheus extrinsic (#2378) * Replace rich.console to btlogging.loggin (#2377) * replace `rich.console` to `btlogging.logging` * update requirements * use whole path import * fix some logging * fix registration.py * ruff * del prometheus.py * fix review comments * Merge pull request #2382 from opentensor/feat/roman/remove-prompt-from-sdk Avoid using `prompt` in SDK * Handle SSL Error on Connection (#2384) * Add `subvortex` subnet and tests (#2395) * add `subvortex` subnet and tests * ruff * Bumps version and updates changelog * bumping up version * Update CHANGELOG.md * bumping version * Update CHANGELOG.md with 8.3.1 * update docker version in config.yml * update docker version in config.yml * remove docker job in config.yml * remove docker job in config.yml 2 --------- Co-authored-by: Roman <167799377+roman-opentensor@users.noreply.github.com> Co-authored-by: ibraheem-opentensor <165814940+ibraheem-opentensor@users.noreply.github.com> Co-authored-by: ibraheem-opentensor <ibraheem@opentensor.dev> Co-authored-by: Roman <roman@opentensor.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK is intended for use in Python scripts and does not provide for interactive things. Due to this it was decided to avoid using the prompt flag and the prompt argument.
Tests are updated.