Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix region handling for the provider #697

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Fix region handling for the provider #697

merged 3 commits into from
Nov 9, 2020

Conversation

outcatcher
Copy link
Contributor

@outcatcher outcatcher commented Nov 9, 2020

Summary of the Pull Request

  • Use region values from provider config and schema
  • Use OS_REGION env var as region default in provider schema
  • Tests: make OS_REGION_NAME to use provider config

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccS3Bucket_basic
--- PASS: TestAccS3Bucket_basic (25.11s)
=== RUN   TestAccAWSS3MultiBucket_withTags
--- PASS: TestAccAWSS3MultiBucket_withTags (27.27s)
=== RUN   TestAccS3Bucket_namePrefix
--- PASS: TestAccS3Bucket_namePrefix (27.02s)
=== RUN   TestAccS3Bucket_generatedName
--- PASS: TestAccS3Bucket_generatedName (27.06s)
=== RUN   TestAccS3Bucket_region
--- PASS: TestAccS3Bucket_region (27.16s)
=== RUN   TestAccS3Bucket_Policy
--- PASS: TestAccS3Bucket_Policy (72.65s)
=== RUN   TestAccS3Bucket_UpdateAcl
--- PASS: TestAccS3Bucket_UpdateAcl (49.43s)
=== RUN   TestAccS3Bucket_Website_Simple
--- PASS: TestAccS3Bucket_Website_Simple (74.89s)
=== RUN   TestAccS3Bucket_WebsiteRedirect
--- PASS: TestAccS3Bucket_WebsiteRedirect (76.92s)
=== RUN   TestAccS3Bucket_WebsiteRoutingRules
--- PASS: TestAccS3Bucket_WebsiteRoutingRules (52.85s)
=== RUN   TestAccS3Bucket_shouldFailNotFound
--- PASS: TestAccS3Bucket_shouldFailNotFound (21.06s)
=== RUN   TestAccS3Bucket_Versioning
--- PASS: TestAccS3Bucket_Versioning (75.27s)
=== RUN   TestAccS3Bucket_Cors
--- PASS: TestAccS3Bucket_Cors (51.61s)
=== RUN   TestAccS3Bucket_Logging
--- PASS: TestAccS3Bucket_Logging (36.69s)
=== RUN   TestAccS3Bucket_Lifecycle
--- PASS: TestAccS3Bucket_Lifecycle (73.20s)
=== RUN   TestS3BucketName
--- PASS: TestS3BucketName (0.00s)
PASS

Process finished with exit code 0

Use `region` values from provider config and schema

Use `OS_REGION` env var as `region` default in provider schema

Tests: fix `OS_REGION_NAME` to use provider config
@outcatcher outcatcher requested a review from lego963 November 9, 2020 10:05
@outcatcher outcatcher changed the title Fix region handling for provider Fix region handling for the provider Nov 9, 2020
@outcatcher outcatcher added the gate Merge PR label Nov 9, 2020
@otc-zuul
Copy link

otc-zuul bot commented Nov 9, 2020

Build succeeded.

@otc-zuul otc-zuul bot merged commit 677d88a into master Nov 9, 2020
@otc-zuul otc-zuul bot deleted the fix/region branch November 9, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants