Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to set security token by env variable #627

Merged
merged 3 commits into from
Sep 28, 2020
Merged

allow to set security token by env variable #627

merged 3 commits into from
Sep 28, 2020

Conversation

cgroschupp
Copy link
Contributor

No description provided.

otc-zuul[bot]
otc-zuul bot previously approved these changes Sep 25, 2020
View reviewed changes
@cgroschupp cgroschupp force-pushed the feat/add-env-os-security-token branch from 036ed8c to bbdd83f Compare September 25, 2020 09:17
otc-zuul[bot]
otc-zuul bot previously approved these changes Sep 25, 2020
View reviewed changes
@lego963
Copy link
Contributor

lego963 commented Sep 25, 2020 •
edited
Loading

@cgroschupp, I was wrong, security token is something another
https://github.com/terraform-provider-openstack/terraform-provider-openstack/blob/master/openstack/provider.go#L102
OS_TOKEN == OS_AUTH_TOKEN
Revert last change :)

@cgroschupp cgroschupp requested a review from lego963 September 25, 2020 10:34
@lego963 lego963 requested a review from outcatcher September 25, 2020 10:35
@outcatcher
Copy link
Contributor

@cgroschupp Your branch is out-of-date with the base. Can you please update your branch?

@cgroschupp
Copy link
Contributor Author

@outcatcher done

@outcatcher outcatcher added the gate Merge PR label Sep 28, 2020
@otc-zuul
Copy link

otc-zuul bot commented Sep 28, 2020

Build succeeded.

@otc-zuul otc-zuul bot merged commit 1e56a59 into opentelekomcloud:master Sep 28, 2020
@cgroschupp cgroschupp deleted the feat/add-env-os-security-token branch September 28, 2020 18:22
@outcatcher outcatcher added this to the v1.20.2 milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otc-zuul otc-zuul[bot] otc-zuul[bot] approved these changes

@lego963 lego963 lego963 approved these changes

@outcatcher outcatcher outcatcher approved these changes

Assignees
No one assigned
Labels
gate Merge PR
Projects
None yet
Milestone
v1.20.2
Development

Successfully merging this pull request may close these issues.
3 participants
@cgroschupp @lego963 @outcatcher