Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] CCE: Fix CCE nodes kubernetes tags issue #2757

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

muneeb-jan
Copy link
Member

@muneeb-jan muneeb-jan commented Dec 10, 2024

Summary of the Pull Request

APIs returning extra k8s tags "node.cce.io/billing-mode" and "node.cce.io/eni-network-mode" which leads to plan differences. We remove these two before returning state.

PR Checklist

  • Tests added/passed.
  • Release notes added.

Acceptance Steps Performed

=== RUN   TestAccResourceCCENodesV3TaintsK8sTags
    resource_opentelekomcloud_cce_node_v3_test.go:440: Cluster is required by the test. 1 test(s) are using cluster.
    cluster.go:121: starting creating shared cluster
=== PAUSE TestAccResourceCCENodesV3TaintsK8sTags
=== CONT  TestAccResourceCCENodesV3TaintsK8sTags
    cluster.go:117: Cluster usage is 0 now, ready to delete the cluster
    cluster.go:80: starting deleting shared cluster
--- PASS: TestAccResourceCCENodesV3TaintsK8sTags (665.46s)
PASS

@muneeb-jan muneeb-jan marked this pull request as ready for review December 10, 2024 11:26
@muneeb-jan muneeb-jan self-assigned this Dec 10, 2024
@muneeb-jan muneeb-jan added the fix bug fixes label Dec 10, 2024
@muneeb-jan muneeb-jan added the gate Merge PR label Dec 10, 2024
Copy link

otc-zuul bot commented Dec 10, 2024

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/35fde85c891d447890781f27c8e510b7

✔️ build-otc-releasenotes SUCCESS in 4m 45s
✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 14s
✔️ golang-make-test SUCCESS in 4m 31s
✔️ golang-make-vet SUCCESS in 2m 44s
✔️ tflint SUCCESS in 2m 37s
✔️ goreleaser-build SUCCESS in 7m 54s

@otc-zuul otc-zuul bot merged commit 2c4d72d into devel Dec 10, 2024
6 checks passed
@otc-zuul otc-zuul bot deleted the fix-cce-node-k8s-tags-issue branch December 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix bug fixes gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants