Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] CCE: Refactor CCE nodes #2756

Merged
merged 7 commits into from
Dec 9, 2024
Merged

[Refactor] CCE: Refactor CCE nodes #2756

merged 7 commits into from
Dec 9, 2024

Conversation

muneeb-jan
Copy link
Member

@muneeb-jan muneeb-jan commented Dec 6, 2024

Summary of the Pull Request

Apply changes from gopher in provider

PR Checklist

  • Tests added/passed.
  • Release notes added.

Acceptance Steps Performed

=== RUN   TestAccResourceCCENodesV3Basic
    resource_opentelekomcloud_cce_node_v3_test.go:45: Cluster is required by the test. 1 test(s) are using cluster.
    cluster.go:121: starting creating shared cluster
    cluster.go:117: Cluster usage is 0 now, ready to delete the cluster
    cluster.go:80: starting deleting shared cluster
--- PASS: TestAccResourceCCENodesV3Basic (742.68s)
=== NAME  TestAccResourceCCENodesV3EncryptedVolume
    cluster.go:117: Cluster is released by the test. 11 test(s) are still using cluster.
--- PASS: TestAccResourceCCENodesV3EncryptedVolume (262.20s)
=== NAME  TestAccResourceCCENodesV3Timeout
    cluster.go:117: Cluster is released by the test. 10 test(s) are still using cluster.
--- PASS: TestAccResourceCCENodesV3Timeout (272.40s)
=== NAME  TestAccResourceCCENodesV3IpNulls
    cluster.go:117: Cluster is released by the test. 9 test(s) are still using cluster.
--- PASS: TestAccResourceCCENodesV3IpNulls (293.45s)
=== NAME  TestAccResourceCCENodesV3IpWithExtendedParameters
    cluster.go:117: Cluster is released by the test. 8 test(s) are still using cluster.
--- PASS: TestAccResourceCCENodesV3IpWithExtendedParameters (303.52s)
=== NAME  TestAccResourceCCENodesV3IpCreate
    cluster.go:117: Cluster is released by the test. 7 test(s) are still using cluster.
--- PASS: TestAccResourceCCENodesV3IpCreate (335.90s)
=== NAME  TestAccResourceCCENodesV3_extendParams
    cluster.go:117: Cluster is released by the test. 5 test(s) are still using cluster.
--- PASS: TestAccResourceCCENodesV3_extendParams (548.83s)
=== NAME  TestAccResourceCCENodesV3Multiple
    cluster.go:117: Cluster is released by the test. 4 test(s) are still using cluster.
--- PASS: TestAccResourceCCENodesV3Multiple (586.56s)
=== NAME  TestAccResourceCCENodesV3_eipIds
    cluster.go:117: Cluster is released by the test. 3 test(s) are still using cluster.
--- PASS: TestAccResourceCCENodesV3_eipIds (676.41s)
=== NAME  TestAccResourceCCENodesV3BandWidthResize
    cluster.go:117: Cluster is released by the test. 2 test(s) are still using cluster.
--- PASS: TestAccResourceCCENodesV3BandWidthResize (915.95s)
=== NAME  TestAccResourceCCENodesV3OS
    cluster.go:117: Cluster is released by the test. 1 test(s) are still using cluster.
--- PASS: TestAccResourceCCENodesV3OS (929.26s)
=== NAME  TestAccResourceCCENodesV3IpSetNull
    cluster.go:117: Cluster usage is 0 now, ready to delete the cluster
    cluster.go:80: starting deleting shared cluster
--- PASS: TestAccResourceCCENodesV3IpSetNull (1143.53s)
PASS

@muneeb-jan muneeb-jan self-assigned this Dec 6, 2024
@muneeb-jan muneeb-jan marked this pull request as ready for review December 6, 2024 16:01
Copy link
Member

@anton-sidelnikov anton-sidelnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@muneeb-jan muneeb-jan added the gate Merge PR label Dec 9, 2024
Copy link

otc-zuul bot commented Dec 9, 2024

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/cd76e78c27b0497193630d71762b7321

✔️ build-otc-releasenotes SUCCESS in 4m 01s
✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 10s
✔️ golang-make-test SUCCESS in 3m 38s
✔️ golang-make-vet SUCCESS in 3m 04s
✔️ tflint SUCCESS in 2m 22s
✔️ goreleaser-build SUCCESS in 8m 03s

@otc-zuul otc-zuul bot merged commit b725af3 into devel Dec 9, 2024
6 checks passed
@otc-zuul otc-zuul bot deleted the cce-refactor-nodes branch December 9, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants