Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network] Doc deprecation message to router_route_v2 and refactoring #2669

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

anton-sidelnikov
Copy link
Member

@anton-sidelnikov anton-sidelnikov commented Oct 1, 2024

Summary of the Pull Request

Resource not presented in docportal, it means that it is deprecated.
But still works, so refactored and added test case with instance recreation.

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccNetworkingV2RouterRoute_basic
=== PAUSE TestAccNetworkingV2RouterRoute_basic
=== CONT  TestAccNetworkingV2RouterRoute_basic
--- PASS: TestAccNetworkingV2RouterRoute_basic (233.55s)
PASS

=== RUN   TestAccNetworkingV2RouterRoute_ecs
=== PAUSE TestAccNetworkingV2RouterRoute_ecs
=== CONT  TestAccNetworkingV2RouterRoute_ecs
--- PASS: TestAccNetworkingV2RouterRoute_ecs (340.75s)
PASS

Debugger finished with the exit code 0

artem-lifshits
artem-lifshits previously approved these changes Oct 1, 2024
@anton-sidelnikov anton-sidelnikov added the gate Merge PR label Oct 1, 2024
Copy link

otc-zuul bot commented Oct 1, 2024

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/80da7d729c1a482ca26cccd6b0307aa9

✔️ build-otc-releasenotes SUCCESS in 3m 54s
✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 14s
✔️ golang-make-test SUCCESS in 3m 48s
✔️ golang-make-vet SUCCESS in 2m 36s
✔️ tflint SUCCESS in 1m 45s
✔️ goreleaser-build SUCCESS in 7m 49s

@otc-zuul otc-zuul bot merged commit 6880166 into devel Oct 1, 2024
3 checks passed
@otc-zuul otc-zuul bot deleted the router-route-v2-depr-doc branch October 1, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants