Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APIGW]: gateway resource implementation #2407

Merged
merged 3 commits into from
Jan 10, 2024
Merged

[APIGW]: gateway resource implementation #2407

merged 3 commits into from
Jan 10, 2024

Conversation

artem-lifshits
Copy link
Member

@artem-lifshits artem-lifshits commented Jan 9, 2024 •
edited
Loading

Summary of the Pull Request

Basic gateway resource introduced for APIGW.

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccAPIGWv2Gateway_basic
=== PAUSE TestAccAPIGWv2Gateway_basic
=== CONT  TestAccAPIGWv2Gateway_basic
--- PASS: TestAccAPIGWv2Gateway_basic (395.95s)
PASS

=== RUN   TestAccAPIGWGatewayV2ImportBasic
--- PASS: TestAccAPIGWGatewayV2ImportBasic (355.57s)
PASS

Process finished with the exit code 0
Process finished with the exit code 0

@artem-lifshits artem-lifshits self-assigned this Jan 9, 2024
anton-sidelnikov
anton-sidelnikov reviewed Jan 9, 2024
View reviewed changes
opentelekomcloud/services/apigw/resource_opentelekomcloud_apigw_gateway_v2.go Outdated
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.All(
validation.StringMatch(regexp.MustCompile("^([\u4e00-\u9fa5A-Za-z][\u4e00-\u9fa5A-Za-z-_0-9]*)$"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf?

@artem-lifshits artem-lifshits added the gate Merge PR label Jan 10, 2024
@otc-zuul otc-zuul
Copy link

otc-zuul bot commented Jan 10, 2024

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/c481d178c31048edad1300c837be1025

✔️ build-otc-releasenotes SUCCESS in 6m 52s
✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 15s
✔️ golang-make-test SUCCESS in 4m 46s
✔️ golang-make-vet SUCCESS in 2m 50s
✔️ tflint SUCCESS in 2m 52s
✔️ goreleaser-build SUCCESS in 9m 35s
✔️ otc-terraform-visualize-main SUCCESS in 6m 58s

@otc-zuul otc-zuul bot merged commit 0610319 into devel Jan 10, 2024
3 checks passed
@otc-zuul otc-zuul bot deleted the apigw branch January 10, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@Persimmonboy Persimmonboy Awaiting requested review from Persimmonboy

@Aloento Aloento Awaiting requested review from Aloento

@vladimirvshivkov vladimirvshivkov Awaiting requested review from vladimirvshivkov

Assignees

@artem-lifshits artem-lifshits

Labels
dependencies documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artem-lifshits @anton-sidelnikov