Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCAAS] refactoring opentelekomcloud_dc_virtual_gateway_v2, deprecation opentelekomcloud_dc_endpoint_group_v2 #2405

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

anton-sidelnikov
Copy link
Member

@anton-sidelnikov anton-sidelnikov commented Jan 8, 2024

Summary of the Pull Request

Impossible to properly use endpoint group separately from virtual gateway because of api structure, cyclic dependecies. Make decision to move endpoint group management under virtual gateway resource.
Added deprecation message to opentelekomcloud_dc_endpoint_group_v2

PR Checklist

Acceptance Steps Performed

=== RUN   TestDirectConnectVirtualGatewayV2Resource_basic
--- PASS: TestDirectConnectVirtualGatewayV2Resource_basic (82.87s)
PASS

Debugger finished with the exit code 0

@anton-sidelnikov anton-sidelnikov added the gate Merge PR label Jan 9, 2024
Copy link

otc-zuul bot commented Jan 9, 2024

Build failed.
https://zuul.otc-service.com/t/eco/buildset/2c92ad6c39bd430c80b4ba3860ebe3a0

✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 11s
✔️ golang-make-test SUCCESS in 4m 27s
✔️ golang-make-vet SUCCESS in 3m 41s
✔️ tflint SUCCESS in 2m 45s
✔️ goreleaser-build SUCCESS in 7m 51s
otc-terraform-visualize-main FAILURE in 5m 41s

Copy link

otc-zuul bot commented Jan 9, 2024

Build failed.
https://zuul.otc-service.com/t/eco/buildset/24e04b84ab3a422881d9cf83a85f2fc3

✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 13s
✔️ golang-make-test SUCCESS in 4m 39s
✔️ golang-make-vet SUCCESS in 3m 34s
✔️ tflint SUCCESS in 2m 57s
✔️ goreleaser-build SUCCESS in 7m 09s
otc-terraform-visualize-main FAILURE in 5m 24s

Copy link

otc-zuul bot commented Jan 9, 2024

Build failed.
https://zuul.otc-service.com/t/eco/buildset/63f93b2cc2db406ab965e0c2cf09a046

✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 15s
✔️ golang-make-test SUCCESS in 4m 29s
✔️ golang-make-vet SUCCESS in 3m 43s
✔️ tflint SUCCESS in 1m 51s
✔️ goreleaser-build SUCCESS in 7m 10s
otc-terraform-visualize-main FAILURE in 6m 57s

Copy link

otc-zuul bot commented Jan 9, 2024

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/74fa0c5ab825479986572dab559f3e35

✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 14s
✔️ golang-make-test SUCCESS in 4m 27s
✔️ golang-make-vet SUCCESS in 3m 40s
✔️ tflint SUCCESS in 2m 55s
✔️ goreleaser-build SUCCESS in 6m 53s
✔️ otc-terraform-visualize-main SUCCESS in 6m 38s

@otc-zuul otc-zuul bot merged commit 2cbbbb8 into devel Jan 9, 2024
3 checks passed
@otc-zuul otc-zuul bot deleted the ref-dc-virtual-gateway branch January 9, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants