Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GAUSSDB]: New resource gaussdb_mysql_instance_v3 #2327

Merged
merged 8 commits into from
Oct 2, 2023
Merged

[GAUSSDB]: New resource gaussdb_mysql_instance_v3 #2327

merged 8 commits into from
Oct 2, 2023

Conversation

artem-lifshits
Copy link
Member

@artem-lifshits artem-lifshits commented Sep 29, 2023 •
edited
Loading

Summary of the Pull Request

New resource to manage GaussDB MySql

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccMysqlGaussdbInstanceV3Basic
--- PASS: TestAccMysqlGaussdbInstanceV3Basic (1090.83s)
=== RUN   TestAccGaussDBMySqlV3_importBasic
--- PASS: TestAccGaussDBMySqlV3_importBasic (227.82s)
PASS

Process finished with the exit code 0

@artem-lifshits artem-lifshits self-assigned this Sep 29, 2023
Aloento
Aloento previously approved these changes Sep 29, 2023
View reviewed changes
@artem-lifshits artem-lifshits added the gate Merge PR label Oct 2, 2023
anton-sidelnikov
anton-sidelnikov requested changes Oct 2, 2023
View reviewed changes
docs/resources/gaussdb_mysql_instance_v3.md
* `update` - Default is 60 minutes.
* `delete` - Default is 30 minutes.

## Import
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check import?

opentelekomcloud/services/gaussdb/resource_opentelekomcloud_gaussdb_mysql_instance_v3.go Outdated
Comment on lines 378 to 379
id := inst.Instance.Id
d.SetId(id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not in oneline?

opentelekomcloud/services/gaussdb/resource_opentelekomcloud_gaussdb_mysql_instance_v3.go Outdated
Comment on lines 409 to 412
if inst.Id == "" {
d.SetId("")
return nil
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? I think this can break the state

@otc-zuul
Copy link

otc-zuul bot commented Oct 2, 2023

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/8a56d2f1e9414521bcdcd664e23cf4a5

✔️ build-otc-releasenotes SUCCESS in 3m 05s
✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 43s
✔️ golang-make-test SUCCESS in 5m 11s
✔️ golang-make-vet SUCCESS in 4m 23s
✔️ tflint SUCCESS in 2m 42s
✔️ goreleaser-build SUCCESS in 7m 03s

@otc-zuul
Copy link

otc-zuul bot commented Oct 2, 2023

Pull request merge failed: 1 review requesting changes and 2 approving reviews by reviewers with write access.

@anton-sidelnikov anton-sidelnikov removed the gate Merge PR label Oct 2, 2023
@Aloento Aloento self-requested a review October 2, 2023 09:00
Aloento
Aloento previously approved these changes Oct 2, 2023
View reviewed changes
@artem-lifshits artem-lifshits added the gate Merge PR label Oct 2, 2023
@otc-zuul
Copy link

otc-zuul bot commented Oct 2, 2023

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/cb070249d63b46429892e20a6f679d86

✔️ build-otc-releasenotes SUCCESS in 4m 52s
✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 2m 55s
✔️ golang-make-test SUCCESS in 4m 27s
✔️ golang-make-vet SUCCESS in 3m 29s
✔️ tflint SUCCESS in 2m 46s
✔️ goreleaser-build SUCCESS in 6m 39s

@otc-zuul otc-zuul bot merged commit a08b6d7 into devel Oct 2, 2023
@otc-zuul otc-zuul bot deleted the gaussdb branch October 2, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@vladimirvshivkov vladimirvshivkov vladimirvshivkov left review comments

@Aloento Aloento Aloento left review comments

@Polina-Gubina Polina-Gubina Awaiting requested review from Polina-Gubina

Assignees

@artem-lifshits artem-lifshits

Labels
dependencies documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artem-lifshits @Aloento @vladimirvshivkov @anton-sidelnikov