Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SWR] Add opentelekomcloud_swr_domain_v2 resource #1127

Merged
merged 8 commits into from
Jun 17, 2021
Merged

[SWR] Add opentelekomcloud_swr_domain_v2 resource #1127

merged 8 commits into from
Jun 17, 2021

Conversation

lego963
Copy link
Contributor

@lego963 lego963 commented Jun 17, 2021

Summary of the Pull Request

Implement opentelekomcloud_swr_domain_v2 resource
Part of: #623

PR Checklist

Acceptance Steps Performed

=== RUN   TestSwrDomainV2Basic
--- PASS: TestSwrDomainV2Basic (50.09s)
PASS

Process finished with the exit code 0

@lego963 lego963 requested review from a team, outcatcher and anton-sidelnikov and removed request for a team June 17, 2021 09:58
outcatcher
outcatcher suggested changes Jun 17, 2021
View reviewed changes
docs/resources/swr_domain_v2.md Outdated Show resolved Hide resolved
docs/resources/swr_domain_v2.md Outdated Show resolved Hide resolved
otc-zuul[bot]
otc-zuul bot previously approved these changes Jun 17, 2021
View reviewed changes
@lego963 lego963 dismissed stale reviews from otc-zuul[bot] and anton-sidelnikov via cdc17fb June 17, 2021 10:10
outcatcher
outcatcher reviewed Jun 17, 2021
View reviewed changes
Copy link
Contributor

@outcatcher outcatcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a more verbose status attribute description

@lego963 lego963 added the gate Merge PR label Jun 17, 2021
@otc-zuul
Copy link

otc-zuul bot commented Jun 17, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit 0ec42ec into devel Jun 17, 2021
@otc-zuul otc-zuul bot deleted the swr-domain branch June 17, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otc-zuul otc-zuul[bot] otc-zuul[bot] approved these changes

@outcatcher outcatcher outcatcher approved these changes

@anton-sidelnikov anton-sidelnikov Awaiting requested review from anton-sidelnikov

Assignees
No one assigned
Labels
dependencies documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lego963 @outcatcher @anton-sidelnikov