[CCE] Add possibility to encrypt data volumes #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new test case with encryption
lego963
requested review from
a team,
outcatcher and
anton-sidelnikov
and removed request for
a team
anton-sidelnikov
previously approved these changes
Jun 10, 2021
lego963
force-pushed
the
cce-volume-encryption
branch
from
1664fe8 to
b0df354
Compare
![otc-zuul[bot]](https://avatars.githubusercontent.com/in/11628?s=60&v=4){kind=small}
outcatcher
suggested changes
Jun 10, 2021
| @@ -16,36 +16,37 @@ import ( | |||
|
|
|||
| var privateIP = "192.168.1.13" | |||
|
|
|||
| func TestAccCCENodesV3_basic(t *testing.T) { | |||
| const nodeName = "opentelekomcloud_cce_node_v3.node_1" | |||
There was a problem hiding this comment.
That's not exactly a Node name, rather a resource name
There was a problem hiding this comment.
I've renamed it to resourceNameNode, because const resourceName has collisions with the same const name in resource_opentelekomcloud_cce_cluster_v3_test
opentelekomcloud/services/cce/resource_opentelekomcloud_cce_node_v3.go
Outdated
Show resolved
Hide resolved
Add note for the CCE node encryption
anton-sidelnikov
approved these changes
Jun 11, 2021
outcatcher
approved these changes
Jun 11, 2021
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add new field
kms_idindata_volumesspec to perform encryption with KMSResolves: #1109
PR Checklist
Acceptance Steps Performed