Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume type verification #817

Closed
4 tasks done
outcatcher opened this issue Jan 28, 2021 · 1 comment
Closed
4 tasks done

Add volume type verification #817

outcatcher opened this issue Jan 28, 2021 · 1 comment
Assignees
Milestone

Comments

@outcatcher
Copy link
Contributor

outcatcher commented Jan 28, 2021

Currently, EVS and ECS resources (maybe also MRS and AS) have validation of volume types based on static list:

				ValidateFunc: validation.StringInSlice([]string{
					"SATA", "SAS", "SSD", "co-p1", "uh-l1",
				}, true),

But availability of some volume types (i.e. "co-p1", "uh-l1") depends on availability zone, so this validation should be done fetching available volume types instead using CustomizeDiff

  • EVS
  • ECS
  • AS
  • MRS
@outcatcher outcatcher modified the milestones: v1.23.0, v1.22.7 Jan 28, 2021
@outcatcher outcatcher self-assigned this Jan 28, 2021
otc-zuul bot pushed a commit that referenced this issue Jan 29, 2021
Add plan-stage ECS dependencies validation

Summary of the Pull Request
Add plan stage validation of VPC and available disk type
PR Checklist

 Refers to: #817
 Tests added/passed.
 Schema updated.

Acceptance Steps Performed
=== RUN   TestAccEcsV1Instance_basic
--- PASS: TestAccEcsV1Instance_basic (177.33s)
=== RUN   TestAccEcsV1Instance_diskTypeValidation
--- PASS: TestAccEcsV1Instance_diskTypeValidation (7.40s)
=== RUN   TestAccEcsV1Instance_VPCValidation
--- PASS: TestAccEcsV1Instance_VPCValidation (181.07s)
PASS

Process finished with exit code 0

Reviewed-by: None <None>
Reviewed-by: Rodion Gyrbu <fpsoff@outlook.com>
Reviewed-by: Anton Sidelnikov <None>
otc-zuul bot pushed a commit that referenced this issue Feb 1, 2021
Add volume type validation for EVS v3

Summary of the Pull Request
Add AZ-based plan-phase volume type validation for opentelekomcloud_evs_volume_v3
PR Checklist

 Refers to: #817
 Tests added/passed.
 Schema updated.

Acceptance Steps Performed
=== RUN   TestAccEvsStorageV3Volume_basic
--- PASS: TestAccEvsStorageV3Volume_basic (35.86s)
=== RUN   TestAccEvsStorageV3Volume_tags
--- PASS: TestAccEvsStorageV3Volume_tags (42.65s)
=== RUN   TestAccEvsStorageV3Volume_image
--- PASS: TestAccEvsStorageV3Volume_image (33.65s)
=== RUN   TestAccEvsStorageV3Volume_timeout
--- PASS: TestAccEvsStorageV3Volume_timeout (25.68s)
=== RUN   TestAccEvsStorageV3Volume_volumeType
--- PASS: TestAccEvsStorageV3Volume_volumeType (2.18s)
PASS

Process finished with exit code 0

Reviewed-by: Anton Sidelnikov <None>
Reviewed-by: Rodion Gyrbu <fpsoff@outlook.com>
Reviewed-by: None <None>
@outcatcher
Copy link
Contributor Author

Done where makes sense

otc-zuul bot pushed a commit that referenced this issue Feb 1, 2021
[as_configuration] refactoring resource

Summary of the Pull Request
Implement empty Read
Remove duplicate validations
Resolves: #818
PR Checklist

 Refers to: #818, #817
 Tests added/passed.
 Documentation updated.

Acceptance Steps Performed
=== RUN   TestAccASV1Configuration_basic
--- PASS: TestAccASV1Configuration_basic (32.17s)
=== RUN   TestAccASV1Configuration_publicIP
--- PASS: TestAccASV1Configuration_publicIP (31.83s)
=== RUN   TestAccASV1Configuration_invalidDiskSize
--- PASS: TestAccASV1Configuration_invalidDiskSize (7.69s)
PASS

Process finished with exit code 0

Reviewed-by: None <None>
Reviewed-by: Anton Sidelnikov <None>
Reviewed-by: Anton Kachurin <katchuring@gmail.com>
Reviewed-by: Rodion Gyrbu <fpsoff@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant