Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WAF] make certificate importable by name #1096

Closed
outcatcher opened this issue May 31, 2021 · 0 comments · Fixed by #1119
Closed

[WAF] make certificate importable by name #1096

outcatcher opened this issue May 31, 2021 · 0 comments · Fixed by #1119
Assignees
@outcatcher
Labels
enhancement
Milestone
v1.24.1

Comments

@outcatcher
Copy link
Contributor

Description of the enhancement

Currently, ID can be got only from API, the console doesn't show ID and OpenStack OTC extensions lack WAF support. Importing by name is much more usable.
@outcatcher outcatcher added this to the v1.24.1 milestone May 31, 2021
@outcatcher outcatcher self-assigned this Jun 10, 2021
This was referenced Jun 10, 2021
Closed
Merged
@otc-zuul otc-zuul bot closed this as completed in #1119 Jun 11, 2021
otc-zuul bot pushed a commit that referenced this issue Jun 11, 2021
@outcatcher
Add possibility to import WAF certificate by name (#1119)
c0748a6 
Add possibility to import WAF certificate by name

Summary of the Pull Request
Use importCertificateByIdOrName for import function
Update gophertelekomcloud SDK to current devel
Resolve #1096
PR Checklist

 Refers to: #1096
 Tests added/passed.
 Documentation updated.
 Schema updated.

Acceptance Steps Performed
=== RUN   TestAccWafCertificateV1_import
--- PASS: TestAccWafCertificateV1_import (14.35s)
PASS

Process finished with the exit code 0

Reviewed-by: Rodion Gyrbu <fpsoff@outlook.com>
Reviewed-by: Anton Sidelnikov <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@outcatcher outcatcher

Labels
enhancement
Projects
None yet
Milestone
v1.24.1
1 participant
@outcatcher