[Platform] Use React for state management in literature section #416
Conversation
|
Is it best to leave them until we are sure no other tweaks for the state mgmt are needed? - all profile pages show only the new literature widget then the old for easy comparison. (Admittedly, it would have been better to leave the original folder name unchanged!) |
No. We have tools as git, GitHub, GitHub spaces and our dev environments to compare and/or revert. It is important for better PRs reviews to be clear about the intended code added/removed |
|
OK, should be cleaner now. |
| // type LiteratureListParameter = { | ||
| // id: string, | ||
| // name: string, | ||
| // entity: any, // ADD LATER | ||
| // BODY_QUERY: string, | ||
| // definition: any, // ADD LATER | ||
| // }; |
| const DetailsDispatchContext = createContext(null as any); | ||
|
|
||
| function literatureReducer(literatureState: LiteratureStateType, action: any) { | ||
| console.log(`LITERATURE REDUCER: ${action.type}`); |
| loadingEntities: false, | ||
| }; | ||
|
|
||
| const LiteratureContext = createContext(null as any); |
There was a problem hiding this comment.
Please use the LiteratureStateType
const LiteratureContex = createContext<LiteratureStateType>(initial_state);| }; | ||
|
|
||
| const LiteratureContext = createContext(null as any); | ||
| const LiteratureDispatchContext = createContext(null as any); |
There was a problem hiding this comment.
For typing the actions, you can use the same pattern of AotF FocusState
| } | ||
|
|
||
| function detailsReducer(detailsState: DetailsStateType, action: any) { | ||
| console.log(`DETAILS REDUCER: ${action.type}`); |
| export function useLiterature() { | ||
| return useContext(LiteratureContext); | ||
| } | ||
|
|
||
| export function useLiteratureDispatch() { | ||
| return useContext(LiteratureDispatchContext); | ||
| } | ||
|
|
||
| export function useSelectedCategories() { | ||
| const { category } = useLiterature(); | ||
| return [...category].sort(); | ||
| } | ||
|
|
||
| export function useDisplayedPublications() { | ||
| const { page, pageSize, litsIds } = useLiterature(); | ||
| return isEmpty(litsIds) ? [] : getPage(litsIds, page, pageSize); | ||
| } | ||
|
|
||
| export function useDetails() { | ||
| return useContext(DetailsContext); | ||
| } | ||
|
|
||
| export function useDetailsDispatch() { | ||
| return useContext(DetailsDispatchContext); |
There was a problem hiding this comment.
👍 Like this approach. cc: @chinmehta
| <Fade in> | ||
| <Box mb={2}> | ||
| <Skeleton height={60} /> | ||
| {/* <Box pt="1px"> */} |
Description
Use React instead of Recoil for state management in literature section.
Issue: #3292
Type of change
How Has This Been Tested?
Checked in dev.
Checklist: