Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add interface with batch operators and refactor the utils #7

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

ireneisdoomed
Copy link
Contributor

@ireneisdoomed ireneisdoomed commented Jul 9, 2024

✨ Context

Addition of Google Batch functions using #678 as reference and refactor of the airflow utils we had in common_airflow to interact with the operators into 3 separate modules:

  • operators relating to dataproc tasks
  • operators relating to batch tasks
  • common utils

For reference on how to use the Batch interactors, use the variant index DAG https://github.com/opentargets/gentropy/blob/dfae8582cce328b5f91ff9edb3cb360814318943/src/airflow/dags/variant_index.py

🛠 What does this PR implement

  • Batch functions are added into utils/batch.py
  • Dataproc functions are moved into utils/dataproc.py
  • check_gcp_folder_exists and read_yaml_config are moved into utils/utils.py
  • All the modules that used these functions have been updated accordingly to import only what is needed

🙈 Missing

Test run of a DAG

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@ireneisdoomed ireneisdoomed requested a review from DSuveges July 9, 2024 11:49
@d0choa d0choa merged commit 772028a into dev Jul 9, 2024
2 checks passed
@d0choa d0choa deleted the il-batch branch July 9, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants