Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop version_engine #940

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

project-defiant
Copy link
Contributor

@project-defiant project-defiant commented Dec 3, 2024

✨ Context

Due to the fact that the version engine that was a concept implemented to fit the datasource version inference directly from provided input parameters and use it as a (dataset triggerer in the airflow orchestration airflow datasets triggers this is no longer in the scope of the gentropy.

Moreover the version reasoning caused more trouble, this is why I decided to remove it from here.

🛠 What does this PR implement

This PR drops the version_engine from the gentropy.

🙈 Missing

The version engine is still valid, it has to be moved to the orchestration and can then trigger the dataset version infernence.

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added documentation Improvements or additions to documentation size-M and removed size-S labels Dec 13, 2024
@project-defiant project-defiant changed the title refactor: drop use_version_from_input flag refactor: drop version_engine Dec 13, 2024
@project-defiant project-defiant marked this pull request as ready for review December 13, 2024 09:24
@project-defiant
Copy link
Contributor Author

@DSuveges hopefully this will simplify a bit.

Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic and references were removed to handle datasource versions. As as consequence, the version information in pre-preprocessed input datasets will no longer available (unless explicitly coded in the configuration paths.).

@DSuveges DSuveges merged commit 4820e65 into dev Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Refactor size-M Step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants